Todd Lipcon has submitted this change and it was merged. Change subject: log: use iterator interface for reading log while rebuilding footer ......................................................................
log: use iterator interface for reading log while rebuilding footer We no longer read all of the entries in the segment into memory, but rather process them one by one. This should improve performance of this operation a little bit, but more importantly, it allows us to remove some complexity from the ReadEntries() function. Change-Id: Ic0547f43ba741a8f189fd0419319b17725d64f95 Reviewed-on: http://gerrit.cloudera.org:8080/3057 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/consensus/log.cc M src/kudu/consensus/log.h M src/kudu/consensus/log_util.cc M src/kudu/consensus/log_util.h 4 files changed, 38 insertions(+), 49 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0547f43ba741a8f189fd0419319b17725d64f95 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
