Adar Dembo has posted comments on this change. Change subject: KUDU-1131. Avoid CHECK failure during compaction when an operation is slow to commit ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/3073/2//COMMIT_MSG Commit Message: Line 21: before this patch, that would have erroneously made the compaction code thing Nit: think http://gerrit.cloudera.org:8080/#/c/3073/2/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: Line 272: void DeltaTracker::CollectStores(vector<shared_ptr<DeltaStore> > *deltas, Nit: while you're here, >> http://gerrit.cloudera.org:8080/#/c/3073/2/src/kudu/tablet/delta_tracker.h File src/kudu/tablet/delta_tracker.h: Line 79: // Flags used for NewDeltaIterator() and CollectStores() below. : enum Flags { : // The default: look at both UNDO and REDO deltas. : NO_FLAGS = 0, : // Do not include at any UNDO deltas. : NO_UNDOS = 1 << 0, : // Do not include any REDO deltas. : NO_REDOS = 1 << 1, : }; Bitwise here is a little strange unless NO_UNDOS | NO_REDOS is actually a useful set of flags. Is it? Otherwise mutually exclusive enumeration seems more in line with the desired semantics. Line 99: Status NewDeltaIterator(const Schema* schema, Nit: some text explaining the behavior? Would be nice to see it for NewDeltaIterator() too; the TODO/schema bits are good but they don't explain what the function as a whole does. Line 212: void CollectStores(vector<std::shared_ptr<DeltaStore> > *stores, Nit: while you're here, >> -- To view, visit http://gerrit.cloudera.org:8080/3073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie16f2c6d190a322c107d60312d4c35d7aa409c43 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
