Adar Dembo has posted comments on this change. Change subject: Remove the use of boost::lock_guard in oid_generator.cc ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3090/2//COMMIT_MSG Commit Message: Line 13: That is, building and linking the client would now require libboost_system to Specifically, libboost_system.a (the static archive). The boost system DSO should, like any x86-64 DSO, always be compiled with -fPIC. Line 14: be compiled with -fPIC, which it isn't in some architectures. Nit: not architectures, but distros. -- To view, visit http://gerrit.cloudera.org:8080/3090 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I224bda0faaf57ed6d6cce0b223d3484317b83342 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
