Adar Dembo has posted comments on this change. Change subject: rpcz: break out trace metrics into separate PB fields ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3092/1/src/kudu/rpc/rpcz_store.cc File src/kudu/rpc/rpcz_store.cc: Line 157: const std::string& child_path, Nit: don't need std:: prefix Line 169: for (const auto& child_pair : t.ChildTraces()) { Is it weird that ChildTraces() and Get() are performed non-atomically w.r.t. one another? Is it possible for t to be mutated in the interim? If so, does it matter? -- To view, visit http://gerrit.cloudera.org:8080/3092 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bd1a249b2f09f8eb63bc64de55147b3d7738a9c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
