Adar Dembo has posted comments on this change.

Change subject: [java client] Get the server logs in test logs
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3113/1/java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java:

Line 132:       tserverProcesses.put(ports.get(i * 2), 
configureAndStartProcess(rpcPort, tsCmdLine));
Map key can now be rpcPort too. Below as well.


Line 407:           LOG.info("{}: {}", port, line);
I'm not sure if port is the best prefix here. PID, something with the binary 
name, maybe full IP address are all good candidates. But let's keep it the way 
you've done it for now and see how easy/hard it is to debug.


http://gerrit.cloudera.org:8080/#/c/3113/1/java/kudu-client/src/test/resources/flags
File java/kudu-client/src/test/resources/flags:

Line 7
Should restore this; the default value is true.


-- 
To view, visit http://gerrit.cloudera.org:8080/3113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc18fbd700871dc21ef6b915c2001302067b364d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to