Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3142
Change subject: KUDU-1386 NaN float and double values are not handled correctly ...................................................................... KUDU-1386 NaN float and double values are not handled correctly Previously, TypeInfo::Compare always returned 0 for comparisons with NaN. This meant that an equality predicate on a floating point column would always return all NaN values for the column. This patch changes Compare to return an enum so that types do not have to be totally ordered- a comparison can return NONCOMPARABLE and not any of LESSER, EQUAL, or GREATER. As a result of this patch, it will not be possible to match NaN values with range or equality predicates. I'll address that in another patch. Change-Id: I194dcddeb8eabcc67699661b9cc9362a99f2f4ae --- A Testing/Temporary/CTestCostData.txt M src/kudu/client/predicate-test.cc M src/kudu/codegen/codegen-test.cc M src/kudu/common/column_predicate.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/scan_spec.cc M src/kudu/common/schema-test.cc M src/kudu/common/schema.h M src/kudu/common/types-test.cc M src/kudu/common/types.cc M src/kudu/common/types.h M src/kudu/tablet/compaction.cc 12 files changed, 145 insertions(+), 59 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/3142/1 -- To view, visit http://gerrit.cloudera.org:8080/3142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I194dcddeb8eabcc67699661b9cc9362a99f2f4ae Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]>
