Todd Lipcon has posted comments on this change. Change subject: KUDU-1459. This patch augments the error sentence at initial startup about the CPU not supporting SSE4.2, with a possible source of the error when running inside a VM and a pointer in the Quickstart/Troubleshooting section of the online documentation. (V ......................................................................
Patch Set 1: (4 comments) Thanks for the contribution! Just a few small items http://gerrit.cloudera.org:8080/#/c/3152/1//COMMIT_MSG Commit Message: Line 7: KUDU-1459. This patch augments the error sentence at initial startup about the CPU not supporting SSE4.2, Do you mind reformatting the commit message to match the style used by other commits? http://chris.beams.io/posts/git-commit/ is a good guide here. http://gerrit.cloudera.org:8080/#/c/3152/1/docs/quickstart.adoc File docs/quickstart.adoc: Line 268: or latest or later Line 268: ttps://www.virtualbox.org/manual/ch09.html#sse412passthrough use asciidoc syntax to name this link (eg "refer to the VirtualBox documentation for SSE4.2 passthrough") also, please hard-wrap the line at 80-100 columns so it's easier to review http://gerrit.cloudera.org:8080/#/c/3152/1/src/kudu/util/init.cc File src/kudu/util/init.cc: Line 34: "you may need to enable SSE4.2 pass-through", add a '.' at the end of the sentence -- To view, visit http://gerrit.cloudera.org:8080/3152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb56a23a528906c04644f36da1386b887328f326 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Cenk Uyan <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
