Will Berkeley has posted comments on this change. Change subject: upsert support ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3145/1/java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/SimpleKuduEventProducer.java File java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/SimpleKuduEventProducer.java: Line 71: Upssert upsert = table.newUpsert(); : PartialRow row = upsert.getRow(); : row.addBinary(payloadColumn, payload); payloadColumn must be the key, since it's the only column specified in the PartialRow, but a key column can't be updated (yet). Hence upsert can only act as an insert, not an update. An update would still be an error. I don't think we can support upserting the binary payload column without separating the payload column from the key column(s). The simple solution I used in my patch was to allow a single string key column value to be specified as an Event header, and then having the key column name be a parameter. -- To view, visit http://gerrit.cloudera.org:8080/3145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id13fa449e74c1c141c681ff5c4eb8f8aa2ec1851 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ara Ebrahimi <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
