tisonkun commented on code in PR #618:
URL: https://github.com/apache/incubator-kvrocks/pull/618#discussion_r888836596
##########
CMakeLists.txt:
##########
@@ -45,6 +45,8 @@ if(NOT DISABLE_JEMALLOC)
list(APPEND EXTERNAL_LIBS PRIVATE jemalloc)
endif()
+set(BUILD_SHARED_LIBS OFF CACHE BOOL "do not build shared libs by default")
Review Comment:
Why do we set this flag on root CMakeLists also?
BTW, the comment seems magic without background (why forbid shared lib?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
