I see patch files and PR basically the same thing. Personally prefer patch file, but PR is fine too.
On Thu, Jan 14, 2016 at 4:48 PM, hongbin ma <[email protected]> wrote: > good point > > in this case we should think about trying out both review ways, and pick > whichever suits us:) > > On Thu, Jan 14, 2016 at 4:45 PM, [email protected] <[email protected]> > wrote: > > > No idea why hadoop and hbase community not utilize github. But spark > > community usually use github > > to send pr and patches. Maybe more flexible to review and merge. > > > > > > > > [email protected] > > > > From: hongbin ma > > Date: 2016-01-14 16:43 > > To: dev > > Subject: Re: Using apache reviewboard for reviewing patches > > I had a impression that asf git is not well integrated with github, so > for > > a long time we tried not to use github. > > > > btw, why do projects like hadoop,hbase not to use github for reviewing? > > > > > > > > > > -- > > Regards, > > > > *Bin Mahone | 马洪宾* > > Apache Kylin: http://kylin.io > > Github: https://github.com/binmahone > > > > > > -- > Regards, > > *Bin Mahone | 马洪宾* > Apache Kylin: http://kylin.io > Github: https://github.com/binmahone >
