----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64244/ -----------------------------------------------------------
(Updated εδΊζ 14, 2017, 10:48 a.m.) Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu. Changes ------- fix bug that kylin also remember checkbox status when the user doesn't submit. Bugs: KYLIN-3076 https://issues.apache.org/jira/browse/KYLIN-3076 Repository: kylin Description ------- In "Monitor>Jobs" page, the defaut setting is to list all the jobs in the last one week, if we only want to see the jobs whose cube named "cube1" and was successfully finished in the last one month, we have to type "cube1" in the filter box, select "LAST ONE MONTH" in the drop-down box, and check the "FINISHED" item in the job status checkbox, then click the "refresh" button, the results we want will come out. But, when we leave this page for a moment, for example, we click "MODEL" menu to see the model infomation and then click "MONITOR" menu to turn back to the monitor page, we will find that all the choices we have made was gone, and have to do it again to filter out the jobs we want. We hope that kylin can remember the choices we have made in the "Monitor>Jobs" page, so we don't have to make the same choices everytime when we enter this page. Diffs (updated) ----- webapp/app/js/controllers/job.js 8e460fae0 webapp/app/js/controllers/page.js 0b5ded742 webapp/app/js/model/jobListModel.js 95e0be3bc Diff: https://reviews.apache.org/r/64244/diff/4/ Changes: https://reviews.apache.org/r/64244/diff/3-4/ Testing ------- Thanks, pengjianhua