zhang1002 commented on a change in pull request #767: URL: https://github.com/apache/incubator-kyuubi/pull/767#discussion_r669457032
########## File path: externals/kyuubi-spark-monitor/src/main/scala/org/apache/kyuubi/engine/spark/monitor/KyuubiStatementMonitor.scala ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kyuubi.engine.spark.monitor + +import java.util.concurrent.ArrayBlockingQueue + +import org.apache.kyuubi.Logging +import org.apache.kyuubi.engine.spark.monitor.entity.KyuubiStatementInfo + +// TODO: Thread Safe need to consider +object KyuubiStatementMonitor extends Logging{ + + /** + * This blockingQueue store kyuubiStatementInfo. + * + * Notice: + * 1. When we remove items from this queue, we should ensure those statements have finished. + * If not, we should put them into this queue again. + * 2. There have two kinds of threshold to trigger when to remove items from this queue: + * a. time + * b. this queue's current size + */ + // TODO: Capacity should make configurable + private val kyuubiStatementQueue = new ArrayBlockingQueue[KyuubiStatementInfo](10) + + /** + * This function is used for putting kyuubiStatementInfo into blockingQueue(statementQueue). + * Every time we put an item into this queue, we should judge this queue's current size at first. + * If the size is less than threshold, we need to remove items from this queue. + * @param kyuubiStatementInfo + */ + // TODO: Lack size type threshold and time type threshold + def putStatementInfoIntoQueue(kyuubiStatementInfo: KyuubiStatementInfo): Unit = { + if (kyuubiStatementQueue.size() >= 7) { Review comment: It just for test. We will make those configurable soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
