Thank Willem for pointing the source release build issue and the license issues, I'm going to cancel this vote and have sent a serials PRs [1][2][3] to fix them.
1. Fixed in #976[2], with this PR, we can build, pass ut and create the binary tarball from source release. 2. The only one which has a different License header is scala.util.Using, removed in #973[1]. 3. Fixed in #978[3]. 4. Fixed in #978[3]. Please help review the PRs, and I will call the next RC vote once those issues got resolved. 1. https://github.com/apache/incubator-kyuubi/pull/973 2. https://github.com/apache/incubator-kyuubi/pull/976 3. https://github.com/apache/incubator-kyuubi/pull/978 Thanks, Cheng Pan Willem Ning Jiang <[email protected]> 于2021年8月22日周日 下午6:09写道： > -1 for this release candidate. > > Here is what I found: > > 1. I tried to build the binary from source release artifact and got this > error. > verify or update kyuubi spark sql functions *** FAILED *** > java.nio.file.NoSuchFileException: > kyuubi-1.3.0-incubating-source/externals/../docs/sql/functions.md > It may relates to change of exclude the docs files from source release. > Normally, we don't need to add the License header to the markdown file and > image files (which are created by ourselves). > Please make sure we can build binary from the source artifacts. > > 2. We are not supposed to add the License header declaration of the third > party source file > Please follow the instruction here[1]. Please just keep the original > third party codes' License header. > > 3. The License file in the source release kit need to specify the source > of third party source code, which could help us trace back the third party > source code. > > 4. The binary kit License should include some information of the source > kit License, as they are sharing the same third party dependencies. > > [1]https://www.apache.org/legal/src-headers.html#3party > > Willem > > > On 2021/08/22 08:49:20, Cheng Pan <[email protected]> wrote: > > Hello Apache Kyuubi PPMC and Community, > > > > Please vote on releasing the following candidate as > > Apache Kyuubi (Incubating) version v1.3.0-incubating. > > > > The VOTE will remain open for at least 72 hours. > > > > [ ] +1 Release this package as Apache Kyuubi v1.3.0-incubating > > [ ] +0 > > [ ] -1 Do not release this package because ... > > > > To learn more about Apache Kyuubi (Incubating), please see > > https://kyuubi.apache.org/ > > > > The tag to be voted on is v1.3.0-incubating-rc2 (commit 217b00a): > > https://github.com/apache/incubator-kyuubi/tree/v1.3.0-incubating-rc2 > > > > The release files, including signatures, digests, etc. can be found at: > > > https://dist.apache.org/repos/dist/dev/incubator/kyuubi/v1.3.0-incubating-rc2/ > > > > Signatures used for Kyuubi RCs can be found in this file: > > https://dist.apache.org/repos/dist/dev/incubator/kyuubi/KEYS > > (Signed by ED4E2E5B) > > > > The staging repository for this release can be found at: > > https://repository.apache.org/content/repositories/orgapachekyuubi-1002/ > > > > The commit list since the last RC: > > > https://github.com/apache/incubator-kyuubi/compare/v1.3.0-incubating-rc1...v1.3.0-incubating-rc2 > > > > FAQ > > > > ================================= > > How can I help test this release? > > ================================= > > > > If you are a Kyuubi user, you can help us test this release by taking > > an existing Kyuubi workload and running on this release candidate, then > > reporting any regressions. > > > > In the Java/Scala, you can add the staging repository to your projects > > resolvers > > and test with the RC (make sure to clean up the artifact cache > before/after > > so > > you don't end up building with a out of date RC going forward). > > > > ============================================================== > > What should happen to GitHub issues still targeting v1.3.0-incubating? > > ============================================================== > > > > Committers should look at those and triage. Extremely important bug > fixes, > > documentation, and API tweaks that impact compatibility should be worked > on > > immediately. Everything else please retarget to an appropriate release. > > > > ======================= > > But my bug isn't fixed? > > ======================= > > > > In order to make timely releases, we will typically not hold the release > > unless > > the bug in question is a regression from the previous release. That being > > said, > > if there is something which is a regression that has not been correctly > > targeted > > please ping me or a committer to help target the issue. > > >
