We have 2 options,

1. change default branch to "master"
2. change default branch to "main"

I think that "+1" means "+1 for master".

Please correct me if this is not what you mean.

Thanks,
Cheng Pan


On Wed, Sep 22, 2021 at 10:05 AM wangsheng <[email protected]>
wrote:

> +1, thanks
>
> > 2021年9月20日 下午1:15,Cheng Pan <[email protected]> 写道:
> >
> > Hi,
> >
> > I propose to change the Kyuubi website git repo[1] default branch from
> > asf-site to master.
> >
> > The asf-site branch is used to publish the final website. Currently, if
> we
> > want to update
> > website, we need to
> > 1) update the source files
> > 2) run `hugo` to compile the source files to static pages
> > 3) push both source files and compiled static pages under `/content` to
> the
> > remote asf-site branch
> >
> > Which is not friendly to developers, and the compiled static pages may be
> > different by
> > using different versions of hugo. Thus, I create a new branch master to
> > only track the
> > source files[2][3], and run `hugo` in GitHub Action when the master
> branch
> > changed[4].
> >
> > I think we should keep the default branch as a source files one rather
> than
> > complied files, that's why I propose this change.
> >
> > Gavin McDonald points[5] that
> >> Github has changed the default to 'main' rather than 'master' these
> days.
> >> It is recommended but not compulsory to do so.
> >
> > Personally, I prefer using 'master' as the default branch, because we use
> > 'master' as
> > the default branch everywhere in past.
> >
> > And I'd like to hear what other people think.
> >
> > [1] https://github.com/apache/incubator-kyuubi-website
> > [2] https://github.com/apache/incubator-kyuubi-website/commit/d53cf338
> > [3] https://github.com/apache/incubator-kyuubi-website/commit/10283922
> > [4] https://github.com/apache/incubator-kyuubi-website/commit/46212f77
> > [5] https://issues.apache.org/jira/browse/INFRA-22340
> >
> > Thanks,
> > Cheng Pan
>
>

Reply via email to