+1

- no blocking issue is opened
- checked GPG signatures
- passed build and test

Thanks,
Cheng Pan

On Mon, Nov 29, 2021 at 1:41 PM Cheng Pan <[email protected]> wrote:
>
> Hi Fu,
>
> https://github.com/apache/incubator-kyuubi/pull/1380 fix the
> downloading issue, please try
>
> ```
> build/mvn compile -pl :kyuubi-download -Pflink-provided
> ```
>
> Thanks,
> Cheng Pan
>
> On Mon, Nov 29, 2021 at 1:38 PM Fu Chen <[email protected]> wrote:
> >
> > As Flink engine support move to target version 1.5.0, shall we revert 
> > PR-1339 <https://github.com/apache/incubator-kyuubi/pull/1339> from branch 
> > v1.4.0? We can't skip downloading the Flink archive when building from 
> > source code now.
> >
> > > 2021年11月29日 上午10:11,Kent Yao <[email protected]> 写道:
> > >
> > > +1, and I have verified,
> > >
> > > - All links of the release files and their checksums are ok
> > > - DISCLAIMER/LICENSE/NOTICE in source and binary releases are ok
> > > - the GPG signatures are ok
> > > - incubating in resource names
> > > - tested the binary release locally
> > > - built the source release sucessfully
> > >
> > > wangsheng <[email protected]> 于2021年11月26日周五 上午11:23写道:
> > >
> > >
> > >>
> > >> With my +1
> > >> Test:
> > >> [success] build source code with ./build/dist --name 1.4.0 --tgz 
> > >> --spark-provided -Pspark-3.2 -Pspark-hadoop-2.7
> > >> [success] running basic job with spark beeline
> > >> [success] running basic job with kyuubi beeline
> > >>
> > >> Thanks,
> > >> Binjie yang
> > >>
> > >>> 2021年11月25日 下午11:40,Fei Wang <[email protected]> 写道:
> > >>>
> > >>> Hello Apache Kyuubi PPMC and Community,
> > >>>
> > >>> Please vote on releasing the following candidate as
> > >>> Apache Kyuubi (Incubating) version v1.4.0-incubating.
> > >>>
> > >>> The VOTE will remain open for at least 72 hours.
> > >>>
> > >>> [ ] +1 Release this package as Apache Kyuubi v1.4.0-incubating
> > >>> [ ] +0
> > >>> [ ] -1 Do not release this package because ...
> > >>>
> > >>> To learn more about Apache Kyuubi (Incubating), please see
> > >>> https://kyuubi.apache.org/
> > >>>
> > >>> The tag to be voted on is v1.4.0-incubating-rc1 (commit afeff68):
> > >>> https://github.com/apache/incubator-kyuubi/tree/v1.4.0-incubating-rc1
> > >>>
> > >>> The release files, including signatures, digests, etc. can be found at:
> > >>> https://dist.apache.org/repos/dist/dev/incubator/kyuubi/v1.4.0-incubating-rc1/
> > >>>
> > >>> Signatures used for Kyuubi RCs can be found in this file:
> > >>> https://dist.apache.org/repos/dist/dev/incubator/kyuubi/KEYS
> > >>>
> > >>> The staging repository for this release can be found at:
> > >>> https://repository.apache.org/content/repositories/orgapachekyuubi-1013/
> > >>>
> > >>> This release is using the release script of the tag 
> > >>> v1.4.0-incubating-rc1.
> > >>>
> > >>>
> > >>> FAQ
> > >>>
> > >>> =================================
> > >>> How can I help test this release?
> > >>> =================================
> > >>>
> > >>> If you are a Kyuubi user, you can help us test this release by taking
> > >>> an existing Kyuubi workload and running on this release candidate, then
> > >>> reporting any regressions.
> > >>>
> > >>> In the Java/Scala, you can add the staging repository to your projects
> > >>> resolvers
> > >>> and test with the RC (make sure to clean up the artifact cache 
> > >>> before/after
> > >>> so
> > >>> you don't end up building with a out of date RC going forward).
> > >>>
> > >>> ==============================================================
> > >>> What should happen to GitHub issues still targeting v1.4.0-incubating?
> > >>> ==============================================================
> > >>>
> > >>> Committers should look at those and triage. Extremely important bug 
> > >>> fixes,
> > >>> documentation, and API tweaks that impact compatibility should be 
> > >>> worked on
> > >>> immediately. Everything else please retarget to an appropriate release.
> > >>>
> > >>> =======================
> > >>> But my bug isn't fixed?
> > >>> =======================
> > >>>
> > >>> In order to make timely releases, we will typically not hold the release
> > >>> unless
> > >>> the bug in question is a regression from the previous release. That 
> > >>> being
> > >>> said,
> > >>> if there is something which is a regression that has not been correctly
> > >>> targeted
> > >>> please ping me or a committer to help target the issue.
> > >>>
> > >>>
> > >>> Thanks,
> > >>> Fei Wang
> > >>>
> > >>
> >

Reply via email to