iodone opened a new issue #1678:
URL: https://github.com/apache/incubator-kyuubi/issues/1678


   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the 
[issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Describe the bug
   
   
https://github.com/apache/incubator-kyuubi/blob/47533100f6f69b02a90985637a8fcc3f2cebb28c/kyuubi-server/src/main/scala/org/apache/kyuubi/operation/ExecuteStatement.scala#L56-L73
   
   `hasResultSet` is set to true by default in the `beforeRun` method. 
`hasResultSet` value can be obtained from `remoteOpHandle`, whether to consider 
setting the value in the `executeStatement` ?
   
   Like this: 
   ```
    private def executeStatement(): Unit = {
       try {
         // We need to avoid executing query in sync mode, because there is no 
heartbeat mechanism
         // in thrift protocol, in sync mode, we cannot distinguish between 
long-run query and
         // engine crash without response before socket read timeout.
         _remoteOpHandle = client.executeStatement(statement, true, 
queryTimeout)
         setHasResultSet(_remoteOpHandle.isHasResultSet) 
       } catch onError()
     }
   ```
   
   
   
   
   ### Affects Version(s)
   
   master/1.4.0
   
   ### Kyuubi Server Log Output
   
   _No response_
   
   ### Kyuubi Engine Log Output
   
   _No response_
   
   ### Kyuubi Server Configurations
   
   _No response_
   
   ### Kyuubi Engine Configurations
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to