Hi Gregor,

On Wednesday, 2007-09-26 13:39:05 +0200, Gregor Hartmann wrote:

> ok here is the script to add KeyIDs to sdf files
> 
> I added it ti the wiki page
> http://wiki.services.openoffice.org/wiki/KeyID_Build

umm.. that

    if ( $line =~ 
/^([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)/
 )

is a bit sloppy because of all the * quantifiers it would also match
a line consisting of only tabs or trailing characters more than the
no-tab/tab combinations given because of a missing $ end-of-text anchor.
That's probably not intended and I suggest to rewrite ([^\t]*)\t as
([^\t]+)\t where field content must be present, and specify the $ anchor
at the end, to get an exact match.


> >I would love to also kick out the l and the o since they can be mixed up 
> >with 1 and 0 but the we would need some more special characters which 
> >IMHO is ugly.

If readability and spelling over phone is important it's worth it, you
might use # and *, for example.

  Eike

-- 
 OOo/SO Calc core developer. Number formatter stricken i18n transpositionizer.
 SunSign   0x87F8D412 : 2F58 5236 DB02 F335 8304  7D6C 65C9 F9B5 87F8 D412
 OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS
 Please don't send personal mail to this [EMAIL PROTECTED] account, which I use 
for
 mailing lists only and don't read from outside Sun. Use [EMAIL PROTECTED] 
Thanks.

Attachment: pgpSUsDWS0Wx8.pgp
Description: PGP signature

Reply via email to