----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37648/#review96665 -----------------------------------------------------------
lens-api/src/main/resources/lens-errors.conf (line 86) <https://reviews.apache.org/r/37648/#comment152288> Let's retain the meaning of old error codes. - Rajat Khandelwal On Aug. 20, 2015, 6:20 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37648/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2015, 6:20 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > When two drivers give two different errors, it results in Internal server > error with LensMultiCauseException.It should compare both errors and give > more approriate one to end user. The error codes are organized in sequential > order. Error code with higher value is being thrown. > > > Diffs > ----- > > lens-api/src/main/resources/lens-errors.conf 3fb191e > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 1fe74e2 > > lens-server-api/src/main/java/org/apache/lens/server/api/error/LensMultiCauseException.java > af9e33a > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c29a1ac > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 2189eb8 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > b3f5d93 > > Diff: https://reviews.apache.org/r/37648/diff/ > > > Testing > ------- > > mvn clean install runs fine. > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.212s] > [INFO] Lens .............................................. SUCCESS [3.014s] > [INFO] Lens API .......................................... SUCCESS [23.728s] > [INFO] Lens API for server and extensions ................ SUCCESS [18.542s] > [INFO] Lens Cube ......................................... SUCCESS [5:19.711s] > [INFO] Lens DB storage ................................... SUCCESS [20.030s] > [INFO] Lens Query Library ................................ SUCCESS [16.741s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:58.268s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [40.291s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.075s] > [INFO] Lens Server ....................................... SUCCESS [6:18.562s] > [INFO] Lens client ....................................... SUCCESS [39.919s] > [INFO] Lens CLI .......................................... SUCCESS [3:22.884s] > [INFO] Lens Examples ..................................... SUCCESS [10.586s] > [INFO] Lens Distribution ................................. SUCCESS [10.094s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:32.958s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.238s] > [INFO] Lens Regression ................................... SUCCESS [14.124s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 23:17.878s > [INFO] Finished at: Thu Aug 20 11:57:34 UTC 2015 > [INFO] Final Memory: 171M/801M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
