----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38212/#review98580 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (line 632) <https://reviews.apache.org/r/38212/#comment155100> Should both flags be false here? lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 1337) <https://reviews.apache.org/r/38212/#comment155101> Why is 1 day look ahead is not doing anything? lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 1360) <https://reviews.apache.org/r/38212/#comment155102> Can we add asserts for both testcube.pt and testcube.it ? Is it possible to add atleast one time value to the assert? If yes, then we can remove compareQueries() and these asserts should be sufficient. - Amareshwari Sriramadasu On Sept. 11, 2015, 7:06 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38212/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 7:06 a.m.) > > > Review request for lens. > > > Bugs: LENS-392 > https://issues.apache.org/jira/browse/LENS-392 > > > Repository: lens > > > Description > ------- > > e.g. for a monthly query with look ahead = 1, if next month partition is not > present, it looks for process time partitions for all days of the next month. > And all of them might not be present. So we should proceed with whichever > ones are present. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java > fc2d85b89e9809a61c982ca78a7d18ffacee76f6 > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java > d52f1686254ab0b9c977af84731888778edacb8a > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java > 1b9a44a6c8ac0280bc79d7e62753d692e8e4cd57 > > lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java > 2caea569a6af1f717bef49491b024441808b5448 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 58d0fa7b3d4b4ffd503b3606c3a42d4713d7ef11 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 7e5184c472b230cbee0c633191283a0368a82949 > > Diff: https://reviews.apache.org/r/38212/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.643s] > [INFO] Lens .............................................. SUCCESS [3.155s] > [INFO] Lens API .......................................... SUCCESS [24.053s] > [INFO] Lens API for server and extensions ................ SUCCESS [22.270s] > [INFO] Lens Cube ......................................... SUCCESS [5:33.467s] > [INFO] Lens DB storage ................................... SUCCESS [19.195s] > [INFO] Lens Query Library ................................ SUCCESS [15.957s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:50.296s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [36.200s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.128s] > [INFO] Lens Server ....................................... SUCCESS [5:36.155s] > [INFO] Lens client ....................................... SUCCESS [38.194s] > [INFO] Lens CLI .......................................... SUCCESS [2:38.445s] > [INFO] Lens Examples ..................................... SUCCESS [8.489s] > [INFO] Lens Distribution ................................. SUCCESS [8.929s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:20.239s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.934s] > [INFO] Lens Regression ................................... SUCCESS [10.544s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:29.260s > [INFO] Finished at: Fri Sep 11 06:41:41 UTC 2015 > [INFO] Final Memory: 193M/1888M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
