----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37526/#review99026 -----------------------------------------------------------
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java (line 84) <https://reviews.apache.org/r/37526/#comment155841> `LensAPIResult` is a generic class. Is it possible to return `LensAPIResult<something>`? lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java (line 87) <https://reviews.apache.org/r/37526/#comment155840> instead of string version of LensConf, is it possible to take a LensConf isntance? lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java (line 129) <https://reviews.apache.org/r/37526/#comment155842> casting won't be necessary if the `getObject` return type is `T` instead of `Object` as it is now. lens-regression/src/main/java/org/apache/lens/regression/core/testHelper/BaseTestClass.java (lines 47 - 61) <https://reviews.apache.org/r/37526/#comment155843> can be replaced by `@Getter` annotations. lens-regression/src/main/java/org/apache/lens/regression/util/Util.java (line 166) <https://reviews.apache.org/r/37526/#comment155846> return type can be `T` now that explicit cast is happening. Note that it's object in line 157. lens-regression/src/main/java/org/apache/lens/regression/util/Util.java (line 174) <https://reviews.apache.org/r/37526/#comment155847> return type. - Rajat Khandelwal On Sept. 14, 2015, 6:40 p.m., Arshad Matin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37526/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 6:40 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > LENS-733 : Add library for lens regression > > > LENS-733 : Add library for lens regression > > > LENS-733 : Add library for lens regression > > > LENS-733 : Add library for lens regression > > > LENS-733 : Add Helper Method for lens-regression > > > Diffs > ----- > > lens-regression/pom.xml 48c5b0c8887f5210cccdc6dccb078f90a7398509 > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryInventory.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java > 8b41dbae3a31fcc86794b751c324609da1c3ac92 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java > aff0e8ea48fc6cb5d6edb31428ab32ef53ab870d > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java > 70cad28fbf0722c34b2fe8c041d0570e86bbabf6 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java > b14b00bda417830a50b48c81e5f2cbe2735896b6 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java > e7bc700c063e914d5c305d6f468f4d7f4ff9cbd4 > > lens-regression/src/main/java/org/apache/lens/regression/core/testHelper/BaseTestClass.java > 2985af46374606bef388e876c28fbcaaa43adc22 > > lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java > 62bd1608dbd1ffcbdc931a1f024b5d73a696bb25 > > lens-regression/src/main/java/org/apache/lens/regression/util/HadoopUtil.java > PRE-CREATION > lens-regression/src/main/java/org/apache/lens/regression/util/Util.java > 0e531e02718ba553868c52d0c0c4ad25a4498e48 > > Diff: https://reviews.apache.org/r/37526/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.903 > s] > [INFO] Lens ............................................... SUCCESS [ 3.844 > s] > [INFO] Lens API ........................................... SUCCESS [ 29.872 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 30.727 > s] > [INFO] Lens Cube .......................................... SUCCESS [ 52.871 > s] > [INFO] Lens DB storage .................................... SUCCESS [ 12.098 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 16.444 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [ 23.530 > s] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 25.832 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 20.170 > s] > [INFO] Lens Server ........................................ SUCCESS [01:14 > min] > [INFO] Lens client ........................................ SUCCESS [ 27.819 > s] > [INFO] Lens CLI ........................................... SUCCESS [ 26.542 > s] > [INFO] Lens Examples ...................................... SUCCESS [ 21.779 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 16.608 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [ 35.379 > s] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 5.195 > s] > [INFO] Lens Regression .................................... SUCCESS [ 23.066 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 07:29 min > [INFO] Finished at: 2015-09-14T16:14:22+05:30 > [INFO] Final Memory: 191M/1455M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Arshad Matin > >
