Can someone take a look? On Fri, Sep 18, 2015 at 4:07 PM, Amareshwari Sriramadasu < [email protected]> wrote:
> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37530/ > > On August 19th, 2015, 5:38 a.m. UTC, *Amareshwari Sriramadasu* wrote: > > lens-ui/app/adapters/AdhocQueryAdapter.js > <https://reviews.apache.org/r/37530/diff/2/?file=1041958#file1041958line9> > (Diff > revision 2) > > 9 > > 'getCubes': 'metastore/cubes', > > Not accepting adhoc queries on dimensions? > > do we need metastore/dimensions as well ? > > On August 20th, 2015, 7:09 a.m. UTC, *Ankeet Maini* wrote: > > When I fetch cubes, its measures and dimensions come as well, and are > discoverable and people can query them. Not sure if I understand your > question completely! > > On August 20th, 2015, 9:32 a.m. UTC, *Amareshwari Sriramadasu* wrote: > > Parallel to Cubes (which have measures and dim-attributes), we have > Dimensions which have dimension tables. I'm talking about querying them > directly. > > On August 20th, 2015, 9:51 a.m. UTC, *Ankeet Maini* wrote: > > As per the current implementation and AFAIK we can query the dimensions via > native table, because for every dimension created a native table would've > been created. > > On August 20th, 2015, 10:01 a.m. UTC, *Amareshwari Sriramadasu* wrote: > > We can query dimensions similar to cubes with cube select. See example > queries > https://github.com/apache/incubator-lens/blob/master/lens-examples/src/main/resources/dimension-queries.sql. > It would good to explore and query dimensions as well through ui. > > On August 21st, 2015, 6:40 a.m. UTC, *Rajat Khandelwal* wrote: > > Yes, on the left side you're showing cubes which on click show the queryable > fields. Dimensions(not dim tables or native tables) also have queryable > fields. > > Secondly, native tables basically take away the abstractions provided to the > user. They are only for debugging purposes, we're not supposed to build any > feature depending on the "functionality" of native tables. Native tables are > not a "functionality", they are a back-door pass. > > On September 1st, 2015, 4:48 a.m. UTC, *Amareshwari Sriramadasu* wrote: > > Native tables are for debugging purpose only if logical tables are created on > top them. Without any cubes/dimensions created, users can query native tables > and make use of features provided by lens wrt query life cycle. > For the same reason, querying native tables should not be discouraged. To > distinguish between existing native tables and physical tables of logical > abstraction, native tables api can take a flag to specify whether it should > include physical tables or not. > > On September 18th, 2015, 10:29 a.m. UTC, *Ankeet Maini* wrote: > > I can definitely take this up in the next cut! > > Sure. you can park an improvement issue for the same. > > > - Amareshwari > > On September 18th, 2015, 10:28 a.m. UTC, Ankeet Maini wrote: > Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat > Khandelwal, sharad agarwal, and Yash Sharma. > By Ankeet Maini. > > *Updated Sept. 18, 2015, 10:28 a.m.* > *Bugs: * LENS-629 <https://issues.apache.org/jira/browse/LENS-629> > *Repository: * lens > Description > > LENS-629 - A new improved web client > > Testing > > No server code added/modified. Just JavaScript! > > Diffs > > - .gitignore (5a356e0) > - lens-ui/LICENSE (PRE-CREATION) > - lens-ui/README.markdown (PRE-CREATION) > - lens-ui/app/actions/AdhocQueryActions.js (PRE-CREATION) > - lens-ui/app/actions/LoginActions.js (PRE-CREATION) > - lens-ui/app/adapters/AdhocQueryAdapter.js (PRE-CREATION) > - lens-ui/app/adapters/AuthenticationAdapter.js (PRE-CREATION) > - lens-ui/app/adapters/BaseAdapter.js (PRE-CREATION) > - lens-ui/app/app.js (PRE-CREATION) > - lens-ui/app/components/AboutComponent.js (PRE-CREATION) > - lens-ui/app/components/AdhocQueryComponent.js (PRE-CREATION) > - lens-ui/app/components/AppComponent.js (PRE-CREATION) > - lens-ui/app/components/CubeSchemaComponent.js (PRE-CREATION) > - lens-ui/app/components/CubeTreeComponent.js (PRE-CREATION) > - lens-ui/app/components/DatabaseComponent.js (PRE-CREATION) > - lens-ui/app/components/HeaderComponent.js (PRE-CREATION) > - lens-ui/app/components/LoaderComponent.js (PRE-CREATION) > - lens-ui/app/components/LoginComponent.js (PRE-CREATION) > - lens-ui/app/components/LogoutComponent.js (PRE-CREATION) > - lens-ui/app/components/QueryBoxComponent.js (PRE-CREATION) > - lens-ui/app/components/QueryDetailResultComponent.js (PRE-CREATION) > - lens-ui/app/components/QueryOperationsComponent.js (PRE-CREATION) > - lens-ui/app/components/QueryPreviewComponent.js (PRE-CREATION) > - lens-ui/app/components/QueryResultsComponent.js (PRE-CREATION) > - lens-ui/app/components/RequireAuthenticationComponent.js > (PRE-CREATION) > - lens-ui/app/components/SidebarComponent.js (PRE-CREATION) > - lens-ui/app/components/TableSchemaComponent.js (PRE-CREATION) > - lens-ui/app/components/TableTreeComponent.js (PRE-CREATION) > - lens-ui/app/constants/AdhocQueryConstants.js (PRE-CREATION) > - lens-ui/app/constants/AppConstants.js (PRE-CREATION) > - lens-ui/app/dispatcher/AppDispatcher.js (PRE-CREATION) > - lens-ui/app/stores/AdhocQueryStore.js (PRE-CREATION) > - lens-ui/app/stores/CubeStore.js (PRE-CREATION) > - lens-ui/app/stores/DatabaseStore.js (PRE-CREATION) > - lens-ui/app/stores/TableStore.js (PRE-CREATION) > - lens-ui/app/stores/UserStore.js (PRE-CREATION) > - lens-ui/app/styles/css/global.css (PRE-CREATION) > - lens-ui/app/styles/css/login.css (PRE-CREATION) > - lens-ui/app/styles/css/query-component.css (PRE-CREATION) > - lens-ui/app/styles/css/tree.css (PRE-CREATION) > - lens-ui/app/styles/less/globals.less (PRE-CREATION) > - lens-ui/config.json (PRE-CREATION) > - lens-ui/index.html (PRE-CREATION) > - lens-ui/package.json (PRE-CREATION) > - lens-ui/pom.xml (PRE-CREATION) > - lens-ui/server.js (PRE-CREATION) > - lens-ui/webpack.config.js (PRE-CREATION) > - pom.xml (adba544) > > View Diff <https://reviews.apache.org/r/37530/diff/> > File Attachments > - License details of NPM packages > <https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt> > -- *Ankeet Maini* *"Just when the caterpillar thought the world was over, it became a butterfly!"*
