> On Sept. 22, 2015, 6:51 p.m., Himanshu Gahlaut wrote: > > lens-server/src/main/java/org/apache/lens/server/query/collect/UnioningWaitingQueriesSelector.java, > > line 67 > > <https://reviews.apache.org/r/38624/diff/1/?file=1081228#file1081228line67> > > > > It is not required to code findUnion method and add unit tests for the > > same. > > > > finding union from a list of sets can be done using already tested code > > from guava in one line as follows: > > > > return Sets.newHashSet(Iterables.concat(candiateQueriesSets);
Makes sense. Fixed. - Akshay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38624/#review100040 ----------------------------------------------------------- On Sept. 23, 2015, 8:46 a.m., Akshay Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38624/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 8:46 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-777 > https://issues.apache.org/jira/browse/LENS-777 > > > Repository: lens > > > Description > ------- > > Intersecting waiting query selector was causing blockage for queries of other > users since it was doing intersection on candidate queries from waiting > queries for a user and for a driver. Fixing this by doing a union on these > candidate sets. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 9e27dd4 > > lens-server/src/main/java/org/apache/lens/server/query/collect/IntersectingWaitingQueriesSelector.java > fee4120 > > lens-server/src/main/java/org/apache/lens/server/query/collect/UnioningWaitingQueriesSelector.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/collect/IntersectingWaitingQueriesSelectorTest.java > 62e371d > > lens-server/src/test/java/org/apache/lens/server/query/collect/UnioningWaitingQueriesSelectorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/38624/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.262s] > [INFO] Lens .............................................. SUCCESS [2.945s] > [INFO] Lens API .......................................... SUCCESS [23.028s] > [INFO] Lens API for server and extensions ................ SUCCESS [22.477s] > [INFO] Lens Cube ......................................... SUCCESS [5:18.653s] > [INFO] Lens DB storage ................................... SUCCESS [21.610s] > [INFO] Lens Query Library ................................ SUCCESS [17.671s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:55.020s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [39.002s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.719s] > [INFO] Lens Server ....................................... SUCCESS [5:52.855s] > [INFO] Lens client ....................................... SUCCESS [37.962s] > [INFO] Lens CLI .......................................... SUCCESS [2:37.386s] > [INFO] Lens Examples ..................................... SUCCESS [8.855s] > [INFO] Lens Distribution ................................. SUCCESS [8.685s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:20.464s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.863s] > [INFO] Lens Regression ................................... SUCCESS [11.057s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:40.637s > [INFO] Finished at: Tue Sep 22 10:22:43 UTC 2015 > [INFO] Final Memory: 178M/1155M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Akshay Goyal > >
