----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38617/#review100339 -----------------------------------------------------------
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java (lines 95 - 110) <https://reviews.apache.org/r/38617/#comment157529> Can we keep this code in AbstractOutputFormatter.java like before.? lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java (line 31) <https://reviews.apache.org/r/38617/#comment157528> Havent seen **created by** tags in other calsses. Pls check lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java (line 210) <https://reviews.apache.org/r/38617/#comment157532> we can use writeObject() and readObject() instead. That way the actual seraliziation flow will get covered too. lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java (line 225) <https://reviews.apache.org/r/38617/#comment157535> should we also capture here, the part of the code that was originally failing (as part of LEN-576 - QueryExecutionServiceImpl.getResultset(QueryHandle)) by creating an instance of LensPersistentResult from the de-serailized formatter information ? That way any changes to LensPersistentResult instance ceration will cause this code to fail(compilation) which can be a hint to the developer to update serailization code also. lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java (lines 396 - 403) <https://reviews.apache.org/r/38617/#comment157534> Should the code to create the dummly List<ColumnDescriptor> columns be moved inside newly created calss MockLensResultSetMetadata? Code duplication will also not happen that way. - Puneet Gupta On Sept. 23, 2015, 6:12 p.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38617/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 6:12 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > The fix involves serializing QueryOutputFormatter > > > Diffs > ----- > > > lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java > ae5af03 > > lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java > e28c17b > > lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java > PRE-CREATION > > lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java > 35d7a00 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java > ef8aeed > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > bed79ac > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java > 0a6cc6b > > lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java > 1e9a182 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 3bc9a4a > > Diff: https://reviews.apache.org/r/38617/diff/ > > > Testing > ------- > > Yes. Tested with all cases of lens persisted,driver persisted and inmemory > result sets. > > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.019 > s] > [INFO] Lens ............................................... SUCCESS [ 4.462 > s] > [INFO] Lens API ........................................... SUCCESS [ 29.054 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 25.465 > s] > [INFO] Lens Cube .......................................... SUCCESS [07:00 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 30.185 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 21.199 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [04:09 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 51.156 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 22.259 > s] > [INFO] Lens Server ........................................ SUCCESS [08:06 > min] > [INFO] Lens client ........................................ SUCCESS [ 47.492 > s] > [INFO] Lens CLI ........................................... SUCCESS [03:46 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 12.575 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 12.408 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [02:06 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.021 > s] > [INFO] Lens Regression .................................... SUCCESS [ 15.657 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 29:48 min > [INFO] Finished at: 2015-09-22T14:45:48+05:30 > [INFO] Final Memory: 228M/3007M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Deepak Barr > >
