-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38402/#review100379
-----------------------------------------------------------

Ship it!



lens-cube/src/main/java/org/apache/lens/cube/metadata/TableReference.java (line 
42)
<https://reviews.apache.org/r/38402/#comment157560>

    We are serializing as `t1.f1->t2.f2[n]`. So `parseBoolean` might not work.


- Rajat Khandelwal


On Sept. 16, 2015, 2:33 p.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38402/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2015, 2:33 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-752
>     https://issues.apache.org/jira/browse/LENS-752
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include :
> - Ability to specify if the destination link in a join chain has 
> many-many-relationship
> - Ability to configure at query to say flatten the fields coming from 
> bridge-table relations
> - Enhance cube query rewriter (mainly the join clause) to add join for bridge 
> table to flatten them
> - Added tests for all new functionality
> - Updated documentation with feature addition
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd 58f68f5 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
> 39441c9 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java 
> e394e20 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> bf27b99 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java 
> 1a37e80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TableReference.java 
> 31fd97b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
> aab2488 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
> c7f1e2a 
>   lens-cube/src/main/resources/olap-query-conf.xml c9b8d0f 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 67f7ab9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
> cb63fad 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> ed472f6 
>   
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
>  f9be6e6 
>   src/site/apt/user/olap-cube.apt ac91955 
>   src/site/apt/user/olap-query-conf.apt 8204c34 
> 
> Diff: https://reviews.apache.org/r/38402/diff/
> 
> 
> Testing
> -------
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.015s]
> [INFO] Lens .............................................. SUCCESS [3.049s]
> [INFO] Lens API .......................................... SUCCESS [25.588s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.759s]
> [INFO] Lens Cube ......................................... SUCCESS [5:09.699s]
> [INFO] Lens DB storage ................................... SUCCESS [20.745s]
> [INFO] Lens Query Library ................................ SUCCESS [16.889s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.677s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.134s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.155s]
> [INFO] Lens Server ....................................... SUCCESS [5:40.844s]
> [INFO] Lens client ....................................... SUCCESS [35.393s]
> [INFO] Lens CLI .......................................... SUCCESS [2:36.188s]
> [INFO] Lens Examples ..................................... SUCCESS [8.233s]
> [INFO] Lens Distribution ................................. SUCCESS [8.400s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.649s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.233s]
> [INFO] Lens Regression ................................... SUCCESS [10.572s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 21:02.117s
> [INFO] Finished at: Wed Sep 16 09:00:28 UTC 2015
> [INFO] Final Memory: 209M/2163M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Reply via email to