----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38857/#review101080 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 1201) <https://reviews.apache.org/r/38857/#comment158400> While we are at it, can we also change the name of this private method to indicate that it gets only NATIVE tables ? Say: getNaviveTablesFromDB lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 1203) <https://reviews.apache.org/r/38857/#comment158401> Again, while we are at it, can this method encapsulate all exceptions in LensException? The cause execption,if any, can be attached to lens exception. This will be cleaner (unless we need special handling for any execption type , which is not the case as of now. NotFoundException has already been addressed earlier in the calling code) as the method will just throw LensException. lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (lines 1208 - 1210) <https://reviews.apache.org/r/38857/#comment158407> Is it possible to use Filter instead to get required tables in one shot. org.apache.hadoop.hive.metastore.IMetaStoreClient.listTableNamesByFilter(String, String, short). Not sure if we can create a specific filter for this case. To create such a filetr we should have a common key that exists for both native and non native tables and has a different value for each. lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 1209) <https://reviews.apache.org/r/38857/#comment158402> Just a thought . Why cant we store MetaStoreClient as a private varaible in this method rather than getting it again and again by getting session first from a map and then the metastore client? - Puneet Gupta On Sept. 29, 2015, 6:59 p.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38857/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 6:59 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Currently, To obtain list of native tables, CubeMetastoreService does the > following - > 1. Fetches the list of tables ( one MetastoreClient call) > 2. Filters out the cube tables from the list. The filtering happens by > looking at the table properties from the Table object. This table object is > obtained with another Metastore call. So, If there are 'n' tables, there will > be 'n' metastore calls. > > Instead of this, we can directly fetch the list of table objects for our list > of table names in a single API call using > getMetaStoreClient().getTableObjectsByName() method. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 37cebfe > > Diff: https://reviews.apache.org/r/38857/diff/ > > > Testing > ------- > > Yes. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.745 > s] > [INFO] Lens ............................................... SUCCESS [ 4.601 > s] > [INFO] Lens API ........................................... SUCCESS [ 31.397 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 28.560 > s] > [INFO] Lens Cube .......................................... SUCCESS [07:04 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 27.465 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 23.361 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [04:14 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 50.792 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 20.551 > s] > [INFO] Lens Server ........................................ SUCCESS [11:11 > min] > [INFO] Lens client ........................................ SUCCESS [ 48.547 > s] > [INFO] Lens CLI ........................................... SUCCESS [03:45 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 11.595 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 13.176 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [02:03 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.752 > s] > [INFO] Lens Regression .................................... SUCCESS [ 15.811 > s] > [INFO] Lens UI ............................................ SUCCESS [ 50.811 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 33:53 min > [INFO] Finished at: 2015-09-29T22:48:22+05:30 > [INFO] Final Memory: 175M/3158M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Deepak Barr > >
