----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38889/#review101107 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (line 696) <https://reviews.apache.org/r/38889/#comment158436> can we make it private instead of package private? Patch looks good to me otherwise. - Raju Bairishetti On Sept. 30, 2015, 9:50 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38889/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2015, 9:50 a.m.) > > > Review request for lens. > > > Bugs: LENS-795 > https://issues.apache.org/jira/browse/LENS-795 > > > Repository: lens > > > Description > ------- > > Changes: > > 1. Missing partition should not matter if the partition is missing on a part > column not required. > 1.1. Look ahead part column's missing partitions are okay > 1.2. Fallback partition columns' missing partitions are to be considered > as missing > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java > b389a8f3a5257833834f389163b27c7040aedf69 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 68ab5ab8a7441635f7acbe61e4ab9192056118cc > > Diff: https://reviews.apache.org/r/38889/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
