We cannot add comments to a json file. https://plus.google.com/+DouglasCrockfordEsq/posts/RK8qyGVaGSr
Also, I've already excluded .json files while pushing for 629. This issue was discussed as part of LENS-629 also. We're good! On Thu, Oct 8, 2015 at 6:49 PM, Raju Bairishetti <raju....@gmail.com> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38758/ > > On October 8th, 2015, 1:15 p.m. UTC, *Raju Bairishetti* wrote: > > Seems there is no licence header file in package.json file. > > We may need to add a check in checkstyle if it is not enforcing header check > on json files. > > > - Raju > > On October 8th, 2015, 1:09 p.m. UTC, Ankeet Maini wrote: > Review request for lens, Ajay Yadava, Amareshwari Sriramadasu, Amruth > Sampath, Bala Nathan, Rajat Khandelwal, Raju Bairishetti, and Yash Sharma. > By Ankeet Maini. > > *Updated Oct. 8, 2015, 1:09 p.m.* > *Bugs: * LENS-782 <https://issues.apache.org/jira/browse/LENS-782> > *Repository: * lens > Description > > LENS-782 UI for Saved/Parametrized queries + Bug fixes/Enhancements > > Testing > > just JavaScript. > > Diffs > > - lens-ui/app/actions/AdhocQueryActions.js (8c2d109) > - lens-ui/app/adapters/AdhocQueryAdapter.js (98f9b49) > - lens-ui/app/adapters/BaseAdapter.js (81b9ddc) > - lens-ui/app/app.js (3e389a7) > - lens-ui/app/components/AdhocQueryComponent.js (66ddf75) > - lens-ui/app/components/AppComponent.js (d7a38f9) > - lens-ui/app/components/CubeSchemaComponent.js (593c54a) > - lens-ui/app/components/CubeTreeComponent.js (241c12f) > - lens-ui/app/components/DatabaseComponent.js (09ee2eb) > - lens-ui/app/components/HeaderComponent.js (5ec3397) > - lens-ui/app/components/LoaderComponent.js (ba11c64) > - lens-ui/app/components/LoginComponent.js (cf95af9) > - lens-ui/app/components/LogoutComponent.js (3fc1627) > - lens-ui/app/components/QueryBoxComponent.js (6d5843c) > - lens-ui/app/components/QueryDetailResultComponent.js (b969a4a) > - lens-ui/app/components/QueryOperationsComponent.js (a17a636) > - lens-ui/app/components/QueryParamRowComponent.js (PRE-CREATION) > - lens-ui/app/components/QueryParamsComponent.js (PRE-CREATION) > - lens-ui/app/components/QueryPreviewComponent.js (fabe383) > - lens-ui/app/components/QueryResultsComponent.js (6e4b8c2) > - lens-ui/app/components/RequireAuthenticationComponent.js (9a755b0) > - lens-ui/app/components/RequireAuthenticationComponent.js (9a755b0) > - lens-ui/app/components/SavedQueriesComponent.js (PRE-CREATION) > - lens-ui/app/components/SavedQueryPreviewComponent.js (PRE-CREATION) > - lens-ui/app/components/SidebarComponent.js (dcc8737) > - lens-ui/app/components/TableSchemaComponent.js (67dc25a) > - lens-ui/app/components/TableTreeComponent.js (026e443) > - lens-ui/app/constants/AdhocQueryConstants.js (3c4f93a) > - lens-ui/app/constants/AppConstants.js (48cd93e) > - lens-ui/app/dispatcher/AppDispatcher.js (31b267c) > - lens-ui/app/stores/AdhocQueryStore.js (7420270) > - lens-ui/app/stores/CubeStore.js (8b20b95) > - lens-ui/app/stores/DatabaseStore.js (9f4490b) > - lens-ui/app/stores/SavedQueryStore.js (PRE-CREATION) > - lens-ui/app/stores/TableStore.js (299d9e8) > - lens-ui/app/stores/UserStore.js (47da021) > - lens-ui/app/styles/css/global.css (131ab46) > - lens-ui/app/styles/css/login.css (b400cfb) > - lens-ui/app/styles/css/query-component.css (a82165e) > - lens-ui/app/styles/css/tree.css (402c9a0) > - lens-ui/app/styles/less/globals.less (c0704dc) > - lens-ui/app/utils/ErrorParser.js (PRE-CREATION) > - lens-ui/index.html (9c20fe9) > - lens-ui/package.json (920b120) > - lens-ui/server.js (e812018) > - lens-ui/webpack.config.js (ab4021f) > > View Diff <https://reviews.apache.org/r/38758/diff/> > -- *Ankeet Maini* *"Just when the caterpillar thought the world was over, it became a butterfly!"*
