> On Oct. 12, 2015, 6:31 a.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java, lines > > 210-213 > > <https://reviews.apache.org/r/38521/diff/8-9/?file=1093751#file1093751line210> > > > > let's also implement `toString` function.
Implemented toString() already :). I can improve toString() method if required. - Raju ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/#review102213 ----------------------------------------------------------- On Oct. 11, 2015, 5:31 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38521/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2015, 5:31 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal. > > > Bugs: LENS-607 > https://issues.apache.org/jira/browse/LENS-607 > > > Repository: lens > > > Description > ------- > > Iterators in java7 and java8 are returning elements in different order. All > most all failures are because of this case. > > Changes: > TestBaseCubeQueries: Changed driver supported storages to single storage > instead of multiple > TestCubeRewriter: Returning diffrent orders in the joins. Separated join part > from the actaul query part and verified join part and remaining query part > separately. > TestStorageUtil: Multiple sets can answer the given partitions. Changed > asserts accordingly. > TestTimeRangeResolver: Changed asserts to cover all the errors. > > *ColumnSQLRewriter* : Changed all data structures to *Linked* datastructures > (Arraylist --> LinkedList, HashSet to LinkedHashSet, HashMap to > LinkedHashMap) to return the elements in insertion order. > > TestColumnSQLRewriter: Changed the order of columns in queries. > > > Diffs > ----- > > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 39441c9 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 0f76c76 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > a58f5fe > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > bde4edd > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > 493b8d6 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java > PRE-CREATION > lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java > 81f515b > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java > cb27d50 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 295b476 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > db09a4b > > Diff: https://reviews.apache.org/r/38521/diff/ > > > Testing > ------- > > Tested on both java7 and java8. Build is successful. Will post the build > artifact summary soon. > > c1mng0pxdty3:lens raju.bairishetti$ java -version > **java version "1.8.0_40"** > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 4.849 > s] > [INFO] Lens ............................................... SUCCESS [ 5.806 > s] > [INFO] Lens API ........................................... SUCCESS [ 31.562 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 23.200 > s] > [INFO] Lens Cube .......................................... SUCCESS [06:19 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 23.015 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 18.249 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [03:11 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 41.094 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 26.188 > s] > [INFO] Lens Server ........................................ SUCCESS [12:38 > min] > [INFO] Lens client ........................................ SUCCESS [ 44.951 > s] > [INFO] Lens CLI ........................................... SUCCESS [04:57 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 11.491 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 19.483 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [02:35 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 7.919 > s] > [INFO] Lens Regression .................................... SUCCESS [ 11.523 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 34:13 min > [INFO] Finished at: 2015-09-19T12:13:27+05:30 > [INFO] Final Memory: 158M/1483M > [INFO] > ------------------------------------------------------------------------ > > > JDK-7: **sun-jdk-1.7.0_55** > > regression-2.4.0-beta-SNAPSHOT-tests.jar > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.999s] > [INFO] Lens .............................................. SUCCESS [2.816s] > [INFO] Lens API .......................................... SUCCESS [23.685s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.093s] > [INFO] Lens Cube ......................................... SUCCESS [5:02.073s] > [INFO] Lens DB storage ................................... SUCCESS [19.937s] > [INFO] Lens Query Library ................................ SUCCESS [15.858s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:50.353s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [37.076s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.348s] > [INFO] Lens Server ....................................... SUCCESS [5:42.566s] > [INFO] Lens client ....................................... SUCCESS [34.983s] > [INFO] Lens CLI .......................................... SUCCESS [2:34.585s] > [INFO] Lens Examples ..................................... SUCCESS [8.688s] > [INFO] Lens Distribution ................................. SUCCESS [8.809s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:28.010s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.393s] > [INFO] Lens Regression ................................... SUCCESS [14.258s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:04.437s > [INFO] Finished at: Sat Sep 19 06:48:15 UTC 2015 > [INFO] Final Memory: 178M/1113M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Raju Bairishetti > >