[ 
https://issues.apache.org/jira/browse/LENS-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962740#comment-14962740
 ] 

Hadoop QA commented on LENS-615:
--------------------------------

Applied patch: 
[rb39191.1.patch|https://issues.apache.org/jira/secure/attachment/12767273/rb39191.1.patch]
 and ran command: mvn clean install. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/137/

> Refactoring of testQueryCommands test case
> ------------------------------------------
>
>                 Key: LENS-615
>                 URL: https://issues.apache.org/jira/browse/LENS-615
>             Project: Apache Lens
>          Issue Type: Improvement
>          Components: client
>            Reporter: Himanshu Gahlaut
>            Assignee: Gabor Liptak
>              Labels: newbie
>         Attachments: rb39191.1.patch, rb39191.patch
>
>
> There are too many test cases running in testQueryCommands test case. It is 
> considerably time consuming to debug a failing test case within  
> testQueryCommands. If these test cases are modularized and broken into 
> separate test cases, it will be much helpful in faster debugging.
> {code}
> @Test
>   public void testQueryCommands() throws Exception {
>     client = new LensClient();
>     
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
>     setup(client);
>     LensQueryCommands qCom = new LensQueryCommands();
>     qCom.setClient(client);
>     resDir = new File("target/results");
>     assertTrue(resDir.exists() || resDir.mkdirs());
>     testExecuteSyncQuery(qCom);
>     testExecuteAsyncQuery(qCom);
>     testSyncResults(qCom);
>     testExplainQuery(qCom);
>     testExplainFailQuery(qCom);
>     testPreparedQuery(qCom);
>     testShowPersistentResultSet(qCom);
>     testPurgedFinishedResultSet(qCom);
>     testFailPreparedQuery(qCom);
>     // run all query commands with query metrics enabled.
>     client = new LensClient();
>     
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
>     client.setConnectionParam("lens.query.enable.metrics.per.query", "true");
>     qCom.setClient(client);
>     String result = qCom.getAllPreparedQueries("all", "", -1, -1);
>     assertEquals(result, "No prepared queries");
>     testExecuteSyncQuery(qCom);
>     testExecuteAsyncQuery(qCom);
>     testSyncResults(qCom);
>     testExplainQuery(qCom);
>     testExplainFailQuery(qCom);
>     testPreparedQuery(qCom);
>     testShowPersistentResultSet(qCom);
>     testPurgedFinishedResultSet(qCom);
>     testFailPreparedQuery(qCom);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to