> On Oct. 20, 2015, 6:59 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 2331 > > <https://reviews.apache.org/r/39434/diff/1/?file=1100863#file1100863line2331> > > > > there's a wrapper `setSelectedDriverQuery` for it. Can we use that?
Looked at it. calling ctx.setSelectedDriverQuery(ctx.getSelectedDriverQuery()) - looked like a no-op and could be easily misunderstood. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39434/#review103221 ----------------------------------------------------------- On Oct. 19, 2015, 10:26 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39434/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 10:26 a.m.) > > > Review request for lens. > > > Bugs: LENS-832 > https://issues.apache.org/jira/browse/LENS-832 > > > Repository: lens > > > Description > ------- > > The fix is to set proper driver query in drivercontext for the selected > driver. > > > Diffs > ----- > > > lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java > 12fb4ce > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java > 44978f2 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 7b15a3c > > Diff: https://reviews.apache.org/r/39434/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.886s] > [INFO] Lens .............................................. SUCCESS [2.778s] > [INFO] Lens API .......................................... SUCCESS [23.153s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.496s] > [INFO] Lens Cube ......................................... SUCCESS [5:05.028s] > [INFO] Lens DB storage ................................... SUCCESS [19.749s] > [INFO] Lens Query Library ................................ SUCCESS [15.540s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:47.901s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [36.542s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.866s] > [INFO] Lens Server ....................................... SUCCESS [8:27.025s] > [INFO] Lens client ....................................... SUCCESS [35.727s] > [INFO] Lens CLI .......................................... SUCCESS [2:34.637s] > [INFO] Lens Examples ..................................... SUCCESS [8.422s] > [INFO] Lens Distribution ................................. SUCCESS [8.488s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:18.345s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.884s] > [INFO] Lens Regression ................................... SUCCESS [15.112s] > [INFO] Lens UI ........................................... SUCCESS [26.721s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 24:08.217s > [INFO] Finished at: Mon Oct 19 09:41:52 UTC 2015 > [INFO] Final Memory: 187M/1611M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
