> On Oct. 26, 2015, 5:03 p.m., Amareshwari Sriramadasu wrote: > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java, > > line 137 > > <https://reviews.apache.org/r/39651/diff/1/?file=1107551#file1107551line137> > > > > Is this required?
Yes. The hardcoded values have been moved to default conf. Loading that here. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39651/#review103996 ----------------------------------------------------------- On Oct. 26, 2015, 5:56 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39651/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 5:56 p.m.) > > > Review request for lens. > > > Bugs: LENS-845 > https://issues.apache.org/jira/browse/LENS-845 > > > Repository: lens > > > Description > ------- > > right now, the replacement strings are hard coded. > > > Diffs > ----- > > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > c6797aa441cf160d45cda74a7ccf9facd3084488 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java > a26acde14c3f71c60cacb9e99290827eb82f5525 > lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml > e94c2f35f998796dd6e40d440db75305c56b9f1d > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > 31c7dadec795141769d12448c9381a6a73482f61 > lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml > 1dc0a85b485232ebb3513f910899d34323042605 > > Diff: https://reviews.apache.org/r/39651/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
