----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39686/#review104165 -----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java (line 77) <https://reviews.apache.org/r/39686/#comment162443> The function doesn't return -1 now. - Rajat Khandelwal On Oct. 27, 2015, 7 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39686/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 7 p.m.) > > > Review request for lens. > > > Bugs: LENS-849 > https://issues.apache.org/jira/browse/LENS-849 > > > Repository: lens > > > Description > ------- > > Added regression test with fix. Also fixed comparison in TestQuery for > non-join queries. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > f81f3d5 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 705f19b > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > b2a15a0 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 2707c4c > > Diff: https://reviews.apache.org/r/39686/diff/ > > > Testing > ------- > > All lens-cube tests succeeded > > > Thanks, > > Amareshwari Sriramadasu > >