----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39680/#review104244 -----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java (line 30) <https://reviews.apache.org/r/39680/#comment162522> would it be possible to add a comment with example input and output ? - Puneet Gupta On Oct. 27, 2015, 3:46 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39680/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 3:46 p.m.) > > > Review request for lens. > > > Bugs: LENS-848 > https://issues.apache.org/jira/browse/LENS-848 > > > Repository: lens > > > Description > ------- > > Will plan to separate properties later. Keeping them for backward > compatibility. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java > PRE-CREATION > lens-api/src/test/java/org/apache/lens/api/util/CommonUtilsTest.java > PRE-CREATION > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 825a039d1de808e85a9909b18865c1989c486743 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java > b14835a3c40eabd9b0939e9be19e41852e5f99c4 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 777f73a7bf9f30c0035b90689de9a83c908a1402 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java > 70815bbb8d89685fd2f3faf14230b8b458270ff1 > lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml > 163ed42daf49a182ead3eca048b3ada6e53e2c0b > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java > 21e5f50dcbcabe4d93b9cfac45191f8f4c129a1e > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 9041709554d67ca1b047e6db24be9cd52127ac5d > lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml > 5594fbfac9d2da6c5a1116db41bfcbedbcf19130 > src/site/apt/admin/config.apt 76cbff07ad72f9a43de62f1166c1f0331b3038c0 > src/site/apt/admin/jdbcdriver-config.apt > 7b42309fb2a3c0d3478c6d0f472f782c69f76f85 > > Diff: https://reviews.apache.org/r/39680/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.414s] > [INFO] Lens .............................................. SUCCESS [3.298s] > [INFO] Lens API .......................................... SUCCESS [27.005s] > [INFO] Lens API for server and extensions ................ SUCCESS [25.469s] > [INFO] Lens Cube ......................................... SUCCESS [5:46.494s] > [INFO] Lens DB storage ................................... SUCCESS [22.510s] > [INFO] Lens Query Library ................................ SUCCESS [19.621s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:57.116s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [40.236s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [19.414s] > [INFO] Lens Server ....................................... SUCCESS [8:21.803s] > [INFO] Lens client ....................................... SUCCESS [36.730s] > [INFO] Lens CLI .......................................... SUCCESS [54.984s] > [INFO] Lens Examples ..................................... SUCCESS [10.850s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.867s] > [INFO] Lens Distribution ................................. SUCCESS [9.404s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:24.110s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.979s] > [INFO] Lens Regression ................................... SUCCESS [13.230s] > [INFO] Lens UI ........................................... SUCCESS [27.486s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 23:47.270s > [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015 > [INFO] Final Memory: 179M/1101M > [INFO] > ------------------------------------------------------------------------ > jdbc driver test cases and checkstyle passed > > > Thanks, > > Rajat Khandelwal > >
