----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/#review105051 -----------------------------------------------------------
Can you add tests with some fields selected being expressions, functions around selected fields (for dimattributes) ? - Amareshwari Sriramadasu On Nov. 3, 2015, 2 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39895/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2015, 2 p.m.) > > > Review request for lens. > > > Bugs: LENS-851 > https://issues.apache.org/jira/browse/LENS-851 > > > Repository: lens > > > Description > ------- > > Will do further cleanup and refactoring. Putting this up for an early review. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java > b95595ade6120c0073c286e073715800b6cdd915 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 450d17202d7a06214ecd997d4bab68fe8351ab3e > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > ea9badd8f0c20644ca2b6e82586fa33f599b781e > lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java > 067a37a29b536a9ff03aae12a396e7bb99f9ba0f > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 15a98dd941bd7b4cb68369fb553d6722956430d6 > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java > 90058260b36879bbc149c3c33198d3daf1179b36 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > d7484d83dc0a3f7810ab2109ec882b19b940803b > > Diff: https://reviews.apache.org/r/39895/diff/ > > > Testing > ------- > > Tested for some queries in the test cases themselves. Need to add proper > asserts. > > > Thanks, > > Rajat Khandelwal > >
