----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review105069 -----------------------------------------------------------
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 516) <https://reviews.apache.org/r/39911/#comment163446> Should this be done in case on Execptions also, as in should we do this in finally clause ? lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 1249) <https://reviews.apache.org/r/39911/#comment163451> What happens to skipped(open) sessions ? do we need to close them later once query execution is over ? lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 1254) <https://reviews.apache.org/r/39911/#comment163450> Can we print session id also here? - Puneet Gupta On Nov. 3, 2015, 6:43 p.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39911/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2015, 6:43 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > OperationHandle-HiveSession mapping is maintained for all active operations. > Now, hive session will only be closed when there are no active operations > running on that session. > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > c96ef20 > > Diff: https://reviews.apache.org/r/39911/diff/ > > > Testing > ------- > > Yes. > > 1. Created session. > 2. Fired a query. > 3. Deleted the session before query finishes. > 4. Query keeps running and finishes eventually. > > > Thanks, > > Deepak Barr > >
