[
https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013422#comment-15013422
]
Raju Bairishetti edited comment on LENS-868 at 11/19/15 12:15 PM:
------------------------------------------------------------------
lens pom.xml:
--------------------
{noformat}
<plugin>
<groupId>io.wcm.maven.plugins</groupId>
<artifactId>nodejs-maven-plugin</artifactId>
<version>${nodejs.plugin.version}</version>
<configuration>
<npmVersion>${npmVersion}</npmVersion>
<nodeJsVersion>${nodeVersion}</nodeJsVersion>
<nodeJsDirectory>${project.basedir}/node</nodeJsDirectory>
<tasks>
<npmInstallTask>
<workingDirectory>${project.basedir}</workingDirectory>
</npmInstallTask>
</tasks>
</configuration>
</plugin>
{noformat}
Changed the ${project.basedir} to ${project.build.directory}. node module was
created in the target directory and build was successful. Did not test the
deployment. I will try to find other ways if any.
[~ankeet.maini] Do you want test deployment with the change?
++ [~amareshwari]
was (Author: raju.bairishetti):
{noformat}
<plugin>
<groupId>io.wcm.maven.plugins</groupId>
<artifactId>nodejs-maven-plugin</artifactId>
<version>${nodejs.plugin.version}</version>
<configuration>
<npmVersion>${npmVersion}</npmVersion>
<nodeJsVersion>${nodeVersion}</nodeJsVersion>
<nodeJsDirectory>${project.basedir}/node</nodeJsDirectory>
<tasks>
<npmInstallTask>
<workingDirectory>${project.basedir}</workingDirectory>
</npmInstallTask>
</tasks>
</configuration>
</plugin>
{noformat}
Changed the ${project.basedir} to ${project.build.directory}. node module was
created in the target directory and build was successful. Did not test the
deployment. I will try to find other ways if any.
[~ankeet.maini] Do you want test deployment with the change?
++ [~amareshwari]
> Should not bundle node & node_modules (generated files) in source-release
> archive file
> --------------------------------------------------------------------------------------
>
> Key: LENS-868
> URL: https://issues.apache.org/jira/browse/LENS-868
> Project: Apache Lens
> Issue Type: Bug
> Components: UI
> Reporter: Raju Bairishetti
> Fix For: 2.4
>
>
> We have seen the node & node_modules files from lens-ui are presented in the
> source-release archive. We should not bundle node & node_modules in the
> release archive.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
