> On Nov. 30, 2015, 5:22 a.m., Amareshwari Sriramadasu wrote: > > Can you add unit tests?
Added one test case for AyncListener pool creation and thread naming. Our initail analysis that if QueryEndNotifier.process(QueryEnded) fails with some exception , the AyncEventListener thread may exit is partailly correct . The therad will exit but the thread pool will cteare a new worker thread automatically. So not adding test case for this scenario. > On Nov. 30, 2015, 5:22 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java, > > line 114 > > <https://reviews.apache.org/r/40761/diff/2/?file=1148070#file1148070line114> > > > > Might result in checkstyle issue with { Did not find this in mvn run > On Nov. 30, 2015, 5:22 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java, > > line 115 > > <https://reviews.apache.org/r/40761/diff/2/?file=1148070#file1148070line115> > > > > Should we add error counters for knowing these exception? > > > > Error name can be getName()_"event_process_errors" > > Puneet Gupta wrote: > I feel its not required separately for each AsyncHandler > We can have at uber level. > In rare cases we will get the value >0 and when that happens we can grep > logs for further details. Drpped at uber level also as each listener is already publishing stats if required. Also the excption behaviour is different for each listerenr. Some catch all execptions and nothing is visible to above layers and some don't. - Puneet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/#review108283 ----------------------------------------------------------- On Dec. 14, 2015, 4:10 a.m., Puneet Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40761/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 4:10 a.m.) > > > Review request for lens. > > > Bugs: LENS-887 > https://issues.apache.org/jira/browse/LENS-887 > > > Repository: lens > > > Description > ------- > > Initial Changes (as discussed in JIRA) > + disabled core pool timeout for AsyncEventListeners (since pool had only > single thread) > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java > 547c008 > lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java > a276828 > > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java > 110624a > lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java > f568b17 > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java > 702a529 > > Diff: https://reviews.apache.org/r/40761/diff/ > > > Testing > ------- > > > Verified Build . > > Verified new Thread Names while debugging. > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.085s] > [INFO] Lens .............................................. SUCCESS [2.889s] > [INFO] Lens API .......................................... SUCCESS [25.083s] > [INFO] Lens API for server and extensions ................ SUCCESS [23.336s] > [INFO] Lens Cube ......................................... SUCCESS [5:57.544s] > [INFO] Lens DB storage ................................... SUCCESS [20.762s] > [INFO] Lens Query Library ................................ SUCCESS [15.393s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:50.461s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [35.760s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.248s] > [INFO] Lens Server ....................................... SUCCESS [9:50.223s] > [INFO] Lens client ....................................... SUCCESS [36.590s] > [INFO] Lens CLI .......................................... SUCCESS [51.185s] > [INFO] Lens Examples ..................................... SUCCESS [9.779s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.037s] > [INFO] Lens Distribution ................................. SUCCESS [8.573s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:20.846s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.013s] > [INFO] Lens Regression ................................... SUCCESS [12.349s] > [INFO] Lens UI ........................................... SUCCESS [27.294s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 24:51.394s > [INFO] Finished at: Sat Nov 28 04:07:51 UTC 2015 > [INFO] Final Memory: 199M/2040M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Puneet Gupta > >
