----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40863/#review110949 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java <https://reviews.apache.org/r/40863/#comment170965> I feel this code is still required for the cases of multi range quereies having where clauses. Please update multi range queries to have where clause. and also add multi fact - multi range query. lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java (line 339) <https://reviews.apache.org/r/40863/#comment170967> Check if static is required? - Amareshwari Sriramadasu On Dec. 14, 2015, 3:15 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40863/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 3:15 p.m.) > > > Review request for lens. > > > Bugs: LENS-552 > https://issues.apache.org/jira/browse/LENS-552 > > > Repository: lens > > > Description > ------- > > includes LENS-851 changes, since I expect this to be merged after LENS-851 > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > b544a670a27f65b65a66affde55c7276438d4daa > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > 0656049dafc0b974104ff1c2f79a98fac934901d > lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java > 94725063c0f9f64682bc0741c409bcefdf0be8ec > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 2338ba70bbdeae90c7a0270f63f5d2c1255b5529 > lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java > b95595ade6120c0073c286e073715800b6cdd915 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > f75a6b9b79ee9330de05c24d8f290b2cd27fcc4a > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > e0759b0b8894ec1d0cca41fa6f897576f8090070 > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > a576f3a6720e5e4454faf0188a43091191b0c787 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > bcfc1f6202da5c4377cf6710525c9655a08ce4cc > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 0c43d9800d27b6c343af2b200ebeff9cf20fa816 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 776021d94cfb3c724970bc81a5d03c58459c7911 > lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java > 6c442333fb42beafac1839907159d775b6f97dce > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > da74713e5656a10144a6298a2a6fea266a11e156 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > 7cea7d5a4491d1185cae845415d90d46cfd825c0 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 1385584e033abe904279a8fd6dfa299f4e48665c > lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java > 113d8deb8284443ae45151aa27852ab97570591e > lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java > de52b0a50b8cec580eb7807669d652a85b71e5f9 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 96b1d054a3c444960c69298d878784a819defd53 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 62cc071237b84c46d69d78eea694eb9b8e9b2fd4 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 3f01dbeb1e27248071ecd78c48daea8b77c87459 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > a5886dc1420a38dee88b8798da3fa386bf713436 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 802ff42cf44e2a51ac984220d57d961f68dec442 > > Diff: https://reviews.apache.org/r/40863/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.211s] > [INFO] Lens .............................................. SUCCESS [4.133s] > [INFO] Lens API .......................................... SUCCESS [26.669s] > [INFO] Lens API for server and extensions ................ SUCCESS [24.038s] > [INFO] Lens Cube ......................................... SUCCESS [6:30.318s] > [INFO] Lens DB storage ................................... SUCCESS [19.100s] > [INFO] Lens Query Library ................................ SUCCESS [14.772s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:00.020s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [40.555s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.922s] > [INFO] Lens Server ....................................... SUCCESS > [10:23.992s] > [INFO] Lens client ....................................... SUCCESS [40.087s] > [INFO] Lens CLI .......................................... SUCCESS [54.969s] > [INFO] Lens Examples ..................................... SUCCESS [11.468s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.983s] > [INFO] Lens Distribution ................................. SUCCESS [9.764s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:31.190s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.913s] > [INFO] Lens Regression ................................... SUCCESS [15.667s] > [INFO] Lens UI ........................................... SUCCESS [27.084s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 26:39.990s > [INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015 > [INFO] Final Memory: 178M/1024M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
