> On Dec. 22, 2015, 2:29 p.m., Amareshwari Sriramadasu wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java, > > line 289 > > <https://reviews.apache.org/r/41033/diff/8/?file=1173786#file1173786line289> > > > > seems doc need change. By default async is false - unspecified default > > value is true. > > Rajat Khandelwal wrote: > if unspecified value is true then the default is true. unspecified value > is the value assumed when value is not provided for this argument. > > Amareshwari Sriramadasu wrote: > Rajat, What i meant here is the following : > > If we do : > > > * "query execute <query-string> " # excutes synchronously. As the > default value for async is false > > * "query execute <query-string> --async" # executes asynchronously. As > the unspecified default value for async is true > > * "query execute <query-string> --async true" # executes asynchronously. > value is specified explicitly. > > * "query execute <query-string> --async false" # executes synchronously. > value is specified explicitly. > > > Please validate the above and update doc accordingly.
You are correct, but Line 287 is not `query execute` command, it's `query results` command. For that, async is by default true, and async false means wait for completion and then show results. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41033/#review111586 ----------------------------------------------------------- On Dec. 23, 2015, 10:34 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41033/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 10:34 a.m.) > > > Review request for lens. > > > Bugs: LENS-836 > https://issues.apache.org/jira/browse/LENS-836 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > e3c08ff1e17feeb6b7d3a5e42599993350e7d166 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 6ebfff7f47a8c98350dbc9466f86312334898b15 > lens-client/src/main/java/org/apache/lens/client/LensClient.java > 8f197e4ec5f9c0cc050643cf7333aeba5eec6e08 > lens-client/src/main/java/org/apache/lens/client/LensStatement.java > 71caa48e7926e6d0f9b486ece71b292ba598be3c > src/site/apt/user/cli.apt 3db53c44900176dc7f062267a200ec5c8ced5f6a > > Diff: https://reviews.apache.org/r/41033/diff/ > > > Testing > ------- > > http://showterm.io/2bbd961fd3bcc859adbc8 > > > Thanks, > > Rajat Khandelwal > >
