> On Dec. 24, 2015, 12:42 p.m., Rajat Khandelwal wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 580 > > <https://reviews.apache.org/r/41679/diff/2/?file=1175374#file1175374line580> > > > > 1. Here everywhere we should pass driver name instead of driver class. > > 2. Should we make a wrapping class(or two classes) for driver errors? > > It'll be a sub-exception class of `LensException`. The constructor can take > > driver instance and exception instance and the driver name can be picked up > > inside the constructor. A lot of code change here is calling > > `this.getClass().getName()`.
Dropping this because on second thought I feel that driver information should be hidden from the user. We can proceed with revision 1 then. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41679/#review111823 ----------------------------------------------------------- On Dec. 23, 2015, 9:16 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41679/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 9:16 p.m.) > > > Review request for lens. > > > Bugs: LENS-908 > https://issues.apache.org/jira/browse/LENS-908 > > > Repository: lens > > > Description > ------- > > Renamed LensHiveErrorCode to LensDriverErrorCode so that all drivers can use > this. > JDBC execution errors moved to LensDriverErrorCode. > > > Diffs > ----- > > lens-api/src/main/resources/lens-errors.conf 06960a0 > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > c7ef8f1 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/LensHiveErrorCode.java > 3bac9e7 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 06552ea > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > d3fa904 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 2ad9fcb > > lens-server-api/src/main/java/org/apache/lens/server/api/error/LensDriverErrorCode.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 69c3f46 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 82afcdc > > Diff: https://reviews.apache.org/r/41679/diff/ > > > Testing > ------- > > Added unit test. mvn clean install runs fine. > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.960s] > [INFO] Lens .............................................. SUCCESS [3.325s] > [INFO] Lens API .......................................... SUCCESS [24.952s] > [INFO] Lens API for server and extensions ................ SUCCESS [22.589s] > [INFO] Lens Cube ......................................... SUCCESS > [11:09.789s] > [INFO] Lens DB storage ................................... SUCCESS [19.723s] > [INFO] Lens Query Library ................................ SUCCESS [14.801s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:08.161s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [40.980s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.805s] > [INFO] Lens Server ....................................... SUCCESS > [10:44.584s] > [INFO] Lens client ....................................... SUCCESS [39.108s] > [INFO] Lens CLI .......................................... SUCCESS [56.894s] > [INFO] Lens Examples ..................................... SUCCESS [10.075s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.038s] > [INFO] Lens Distribution ................................. SUCCESS [9.969s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:29.284s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.976s] > [INFO] Lens Regression ................................... SUCCESS [13.449s] > [INFO] Lens UI ........................................... SUCCESS [27.977s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 31:43.393s > [INFO] Finished at: Wed Dec 23 06:57:05 UTC 2015 > [INFO] Final Memory: 178M/1027M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
