> On Dec. 31, 2015, 3:10 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, > > lines 1198-1201 > > <https://reviews.apache.org/r/41798/diff/1/?file=1178494#file1178494line1198> > > > > Not sure if design wise this is the best way to handle this . Should > > there be a cache instead? But keeping cache in sync with metastore may not > > be trivial? > > > > Others can comment too from design perspective.. > > Rajat Khandelwal wrote: > Design seems okay, but I think it shouldn't be `lens.session` level > property. See the fail on partial property.
Ok. Should I make this lens.cube.tables.exclude ? - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41798/#review112373 ----------------------------------------------------------- On Dec. 30, 2015, 1:18 p.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41798/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2015, 1:18 p.m.) > > > Review request for lens. > > > Bugs: LENS-910 > https://issues.apache.org/jira/browse/LENS-910 > > > Repository: lens > > > Description > ------- > > Added a session config parameter lens.session.filter.cube.tables. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 88e5a01 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > cf49a13 > lens-server/src/main/resources/lenssession-default.xml 52e0cd0 > src/site/apt/admin/session-config.apt 5ed51c3 > > Diff: https://reviews.apache.org/r/41798/diff/ > > > Testing > ------- > > Yes. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [ 1.989 s] > [INFO] Lens .............................................. SUCCESS [ 2.584 s] > [INFO] Lens API .......................................... SUCCESS [ 15.955 s] > [INFO] Lens API for server and extensions ................ SUCCESS [ 15.617 s] > [INFO] Lens Cube ......................................... SUCCESS [13:22 min] > [INFO] Lens DB storage ................................... SUCCESS [ 23.206 s] > [INFO] Lens Query Library ................................ SUCCESS [ 13.679 s] > [INFO] Lens Hive Driver .................................. SUCCESS [03:42 min] > [INFO] Lens Driver for JDBC .............................. SUCCESS [ 37.236 s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [ 14.943 s] > [INFO] Lens Server ....................................... FAILURE [09:59 min] > [INFO] Lens Server ....................................... SUCCESS [10:21 min] > [INFO] Lens client ....................................... SUCCESS [ 34.182 s] > [INFO] Lens CLI .......................................... SUCCESS [01:00 min] > [INFO] Lens Examples ..................................... SUCCESS [ 6.170 s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [ 1.443 s] > [INFO] Lens Distribution ................................. SUCCESS [ 7.669 s] > [INFO] Lens ML Lib ....................................... SUCCESS [01:32 min] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [ 1.992 s] > [INFO] Lens Regression ................................... SUCCESS [ 9.155 s] > [INFO] Lens UI ........................................... SUCCESS [ 49.421 s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 14:45 min > [INFO] Finished at: 2015-12-30T18:43:59+05:30 > [INFO] Final Memory: 150M/2661M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Deepak Barr > >
