> On Jan. 25, 2016, 6:06 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java, > > line 128 > > <https://reviews.apache.org/r/42707/diff/1/?file=1219151#file1219151line128> > > > > The comment is not valid now?
Yes. The Dimensions being destinations in auto join resolution has been removed in LENS-735 - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42707/#review116044 ----------------------------------------------------------- On Jan. 25, 2016, 6:04 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42707/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 6:04 a.m.) > > > Review request for lens. > > > Bugs: LENS-927 > https://issues.apache.org/jira/browse/LENS-927 > > > Repository: lens > > > Description > ------- > > The failure is because the JoinTree construction is picking the alias from > query, which is not required. Removing the same, fixed the failure. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java > acc9d5c > lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java > 197847c > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > d7707a9 > > Diff: https://reviews.apache.org/r/42707/diff/ > > > Testing > ------- > > All cube tests passed. Running full suite. > > > Thanks, > > Amareshwari Sriramadasu > >
