----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42850/#review116573 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java (line 81) <https://reviews.apache.org/r/42850/#comment177599> Thinking of changing the message to : A. Query Result is cached in the server temporarily and is accessible until <time> or B. Query result is available in the sever and will be accessible until <time> +1 for A - Puneet Gupta On Jan. 27, 2016, 11:29 a.m., Puneet Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42850/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 11:29 a.m.) > > > Review request for lens. > > > Bugs: LENS-909 > https://issues.apache.org/jira/browse/LENS-909 > > > Repository: lens > > > Description > ------- > > We should avoid sending email notification with inmemory results > > **Note :This is an incremental patch on top of lens-921 (as it needs few > configrations added in lens-921)** > Changes wrt to lens-921 are done in following files only > * lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java > * > lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > a3dbfc0 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java > c64a3dd > > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java > ca00b4d > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 2dff9af > lens-server/src/main/resources/lensserver-default.xml cac641a > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java > 4ac42b2 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 494bce5 > src/site/apt/admin/config.apt 54f827e > src/site/apt/admin/session-config.apt 05a2c2c > > Diff: https://reviews.apache.org/r/42850/diff/ > > > Testing > ------- > > [INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml > to > /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s] > [INFO] Lens .............................................. SUCCESS [3.340s] > [INFO] Lens API .......................................... SUCCESS [20.204s] > [INFO] Lens API for server and extensions ................ SUCCESS [17.930s] > [INFO] Lens Cube ......................................... SUCCESS > [11:47.315s] > [INFO] Lens DB storage ................................... SUCCESS [15.304s] > [INFO] Lens Query Library ................................ SUCCESS [12.357s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s] > [INFO] Lens Server ....................................... SUCCESS [8:58.139s] > [INFO] Lens client ....................................... SUCCESS [30.351s] > [INFO] Lens CLI .......................................... SUCCESS [45.652s] > [INFO] Lens Examples ..................................... SUCCESS [6.089s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s] > [INFO] Lens Distribution ................................. SUCCESS [7.953s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s] > [INFO] Lens Regression ................................... SUCCESS [10.147s] > [INFO] Lens UI ........................................... SUCCESS [28.590s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 28:27.663s > [INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016 > [INFO] Final Memory: 154M/2035M > [INFO] > ------------------------------------------------------------------------ > > > **Email Message looks like this** > (org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 > (localhost [127.0.0.1]) > by localhost > with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8; > Mon, 25 Jan 2016 21:05:25 +0530 (IST) > Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST) > From: [email protected] > To: foo@localhost > Cc: foo1@localhost > Cc: foo2@localhost > Cc: foo3@localhost > Message-ID: <1254092134.01453736125504.JavaMail.puneet.gupta@IM1995-X0> > Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02 > MIME-Version: 1.0 > Content-Type: multipart/mixed; > boundary="----=_Part_0_748061076.1453736125428" > > ------=_Part_0_748061076.1453736125428 > Content-Type: text/plain; charset=us-ascii > Content-Transfer-Encoding: 7bit > > *Query Result is availabe in server and can be accessed until 2016-01-25 > 07:05:46 PM, IST* > ------=_Part_0_748061076.1453736125428-- > > > Thanks, > > Puneet Gupta > >
