> On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote: > > lens-api/src/main/resources/cube-0.1.xsd, line 692 > > <https://reviews.apache.org/r/42909/diff/1/?file=1224917#file1224917line692> > > > > Seems there are multiple typos.
Not a typo. Field name "type" is reserved in JSON. So, used typ. Any other suggestions? > On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote: > > lens-api/src/main/java/org/apache/lens/api/APIResult.java, line 38 > > <https://reviews.apache.org/r/42909/diff/1/?file=1224903#file1224903line38> > > > > Removal necessary? Yes. Was necessary for JSON unmarshalling. > On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote: > > lens-api/src/main/java/org/apache/lens/api/Priority.java, line 36 > > <https://reviews.apache.org/r/42909/diff/1/?file=1224906#file1224906line36> > > > > Don't we require `@XmlEnumValue("HIGH")` etc on individual values? I think not required, will remove from APIResult.Status also. > On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java, > > lines 1246-1247 > > <https://reviews.apache.org/r/42909/diff/1/?file=1224926#file1224926line1246> > > > > Changing the API? Yes. Could not pass XDimensionTable in multi form data through json. and MultiFormData was not required here. > On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote: > > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java, line > > 90 > > <https://reviews.apache.org/r/42909/diff/1/?file=1224933#file1224933line90> > > > > Has that always been a bug? :o Yes. Not failing with earlier grizzly versions. > On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote: > > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java, line > > 257 > > <https://reviews.apache.org/r/42909/diff/1/?file=1224933#file1224933line257> > > > > static? Only used in subclasses. > On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote: > > pom.xml, lines 966-968 > > <https://reviews.apache.org/r/42909/diff/1/?file=1224949#file1224949line966> > > > > could probably look for other possible exclusins All dependencies checked. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42909/#review116766 ----------------------------------------------------------- On Jan. 28, 2016, 12:40 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42909/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 12:40 p.m.) > > > Review request for lens. > > > Bugs: LENS-920 > https://issues.apache.org/jira/browse/LENS-920 > > > Repository: lens > > > Description > ------- > > Changes include : > - Moving to latest jersey, grizzly and jaxb versions > - Enable Moxy json features explicitly > - Fixing a bug in LensJerseyTest for starting tests on random port > - Annotate all enum classes with @XmlEnum > - Write JAXB adapter for UUID > - In Json the name of the field as "type" is reserved. Had to change all the > occurrances. > - Fix signatures wrt LensAPIResult<? extends QuerySubmitResult> > - Update all tests to run against both XML and JSON marshalling/unmarshalling > - JSON requires all JAXBElement classes to be written as GenericEntity. Fixed > TestMetastoreService wrt the same. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d > lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6 > lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6 > lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d > lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d > lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184 > lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java > 756287e > > lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java > 28d9710 > lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e > lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java > d0c21a7 > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java > aa4dc13 > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java > c124a38 > lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c > lens-api/src/main/resources/cube-0.1.xsd d195b08 > lens-client/pom.xml 5f2f3a9 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > 30a7e2c > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java > c64a3dd > > lens-server/src/main/java/org/apache/lens/server/MoxyJsonConfigurationContextResolver.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/error/LensExceptionMapper.java > 1bb65ca > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > fc67df1 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 70323d3 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java > 520c698 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > fb937c6 > lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java > 9db034a > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > bb4cfd2 > > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java > 5c247be > lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java > a499968 > > lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java > faaf172 > lens-server/src/main/resources/lensserver-default.xml cac641a > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > 8f52ddd > lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java > 94dd394 > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java > 75f21e1 > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > 877200f > > lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java > 5301162 > > lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java > 4b25fd0 > lens-server/src/test/java/org/apache/lens/server/common/TestDataUtils.java > 0400519 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 925fc86 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java > 85580da > > lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java > 515ac13 > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 6f8886c > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java > ab42a3d > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java > 4ac42b2 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 3facded > > lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java > 30d1e34 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 3055ce5 > pom.xml 746204e > > Diff: https://reviews.apache.org/r/42909/diff/ > > > Testing > ------- > > All server tests are passing. > Pending: > Client tests > Updating examples > > > Thanks, > > Amareshwari Sriramadasu > >
