----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43600/#review119432 -----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java (line 763) <https://reviews.apache.org/r/43600/#comment180806> What is regex change for? - Amareshwari Sriramadasu On Feb. 17, 2016, 9:56 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43600/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2016, 9:56 a.m.) > > > Review request for lens. > > > Bugs: LENS-960 > https://issues.apache.org/jira/browse/LENS-960 > > > Repository: lens > > > Description > ------- > > Current scenario: > {noformat} > toString(parse("a or b or c or d")) == "(a or (b or (c or (d))))" > {noformat} > > Proposal is to remove the excessive nested braces. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > fdef3f1336534904bddaf430240d9c8e163d66ee > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 1d275589f43572a82b1fdb12a6606cc441b2ee37 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 45b43348c472778af6a118ec38982ee13ab33cf6 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionContext.java > 669a8e94d312bf58a2e559a935435da6f7d972c9 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java > 4afd4037e4c969796a0c7a25cd32438a7d4e7b8f > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 561452747da67feeab1f08fddbc8615324d2737f > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > c412cf0701c5c0ca70aae14e48143d509a143254 > > Diff: https://reviews.apache.org/r/43600/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.913s] > [INFO] Lens .............................................. SUCCESS [2.229s] > [INFO] Lens API .......................................... SUCCESS [14.912s] > [INFO] Lens API for server and extensions ................ SUCCESS [8.950s] > [INFO] Lens Cube ......................................... SUCCESS > [13:17.897s] > [INFO] Lens DB storage ................................... SUCCESS [17.836s] > [INFO] Lens Query Library ................................ SUCCESS [8.737s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:50.534s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [29.858s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [7.778s] > [INFO] Lens Server ....................................... SUCCESS > [16:18.667s] > [INFO] Lens client ....................................... SUCCESS [23.100s] > [INFO] Lens CLI .......................................... SUCCESS [43.857s] > [INFO] Lens Examples ..................................... SUCCESS [3.091s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.376s] > [INFO] Lens Distribution ................................. SUCCESS [9.631s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:08.303s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.929s] > [INFO] Lens Regression ................................... SUCCESS [2.680s] > [INFO] Lens UI ........................................... SUCCESS [30.230s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 38:04.886s > [INFO] Finished at: Wed Feb 17 09:43:49 UTC 2016 > [INFO] Final Memory: 207M/1950M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
