----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44180/#review122511 -----------------------------------------------------------
Ship it! lens-ui/app/adapters/AdhocQueryAdapter.js (line 123) <https://reviews.apache.org/r/44180/#comment184559> Shouldn't we always be using existing methods for constructing full url based on base url and query params? - Rajat Khandelwal On March 8, 2016, 6:58 p.m., Ankeet Maini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44180/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 6:58 p.m.) > > > Review request for lens, Amareshwari Sriramadasu, Deepak Barr, and Rajat > Khandelwal. > > > Repository: lens > > > Description > ------- > > Fixes LENS UI module after API contracts change. > > > Diffs > ----- > > lens-ui/app/actions/AdhocQueryActions.js 284c781 > lens-ui/app/adapters/AdhocQueryAdapter.js 376068b > lens-ui/app/adapters/BaseAdapter.js 634b974 > lens-ui/app/components/CubeSchemaComponent.js c56cb15 > lens-ui/app/components/QueryDetailResultComponent.js 096adde > lens-ui/app/components/QueryParamRowComponent.js 89c8a8e > lens-ui/app/components/TableSchemaComponent.js 7abab95 > lens-ui/app/components/TableTreeComponent.js 799dc9f > lens-ui/app/stores/AdhocQueryStore.js 3f880bf > lens-ui/app/stores/CubeStore.js 09b469f > lens-ui/app/stores/DatabaseStore.js 79894cf > lens-ui/app/stores/SavedQueryStore.js fb2869b > lens-ui/app/stores/TableStore.js 5ef84fa > lens-ui/app/stores/UserStore.js ee5506f > lens-ui/package.json b21302b > > Diff: https://reviews.apache.org/r/44180/diff/ > > > Testing > ------- > > UI looks good with this. Saved Query module needs to be tested, along with > in-memory result mode. This diff is w.r.t to current-release-line branch. > > > Thanks, > > Ankeet Maini > >
