> On March 22, 2016, 4:41 a.m., Puneet Gupta wrote: > > lens-api/src/main/java/org/apache/lens/api/TimeLines.java, line 71 > > <https://reviews.apache.org/r/45100/diff/1/?file=1308326#file1308326line71> > > > > All implementations of PartitionTimeline do not support holes. Should > > this TimeLine be more verstalie (and not map each implemenatation to holes) > > and show the details based on which implementation of PartitionTimeline is > > being used ?
All implementations do not contain holes as a separate field but we can derive holes, that is exactly what we have done here. > On March 22, 2016, 4:41 a.m., Puneet Gupta wrote: > > lens-api/src/main/java/org/apache/lens/api/TimeLines.java, lines 34-45 > > <https://reviews.apache.org/r/45100/diff/1/?file=1308326#file1308326line34> > > > > Comments are out of sync Thanks for catching it, will fix. > On March 22, 2016, 4:41 a.m., Puneet Gupta wrote: > > lens-api/src/main/java/org/apache/lens/api/TimeLines.java, lines 76-77 > > <https://reviews.apache.org/r/45100/diff/1/?file=1308326#file1308326line76> > > > > Should we have a new line between fields . Not sure of how it ll look > > in CLI though. > > If possible pls share a snapshot from cli. I did not do it as it will vary with screen size and particular values of the fields(small names vs long descriptive storage table names etc.) Should we can open another JIRA to address these things across the board? - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45100/#review124722 ----------------------------------------------------------- On March 21, 2016, 12:15 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45100/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 12:15 p.m.) > > > Review request for lens. > > > Bugs: LENS-819 > https://issues.apache.org/jira/browse/LENS-819 > > > Repository: lens > > > Description > ------- > > Timeline of the fact returned should have structure instead of String. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/TimeLines.java PRE-CREATION > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > 6457bce > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 9670d8f > lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > d0f2b57 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 02bbbbd > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java > c588dc7 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java > 1642482 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java > 6c9eb7a > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java > a6cb8da > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 42decc6 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > c11fd83 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > a1acd1a > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 684e2ed > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 3b091f5 > > Diff: https://reviews.apache.org/r/45100/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.545 > s] > [INFO] Lens ............................................... SUCCESS [ 2.307 > s] > [INFO] Lens API ........................................... SUCCESS [ 20.447 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 16.574 > s] > [INFO] Lens Cube .......................................... SUCCESS [20:52 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 38.239 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 11.201 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:40 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 51.661 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.836 > s] > [INFO] Lens Server ........................................ SUCCESS [12:42 > min] > [INFO] Lens client ........................................ SUCCESS [ 48.640 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:27 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 8.238 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.713 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 8.405 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:26 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 1.610 > s] > [INFO] Lens Regression .................................... SUCCESS [ 10.090 > s] > [INFO] Lens UI ............................................ SUCCESS [ 45.105 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 44:49 min > [INFO] Finished at: 2016-03-21T17:35:07+05:30 > [INFO] Final Memory: 145M/623M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Ajay Yadava > >
