----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45286/#review125588 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/LensServices.java (line 194) <https://reviews.apache.org/r/45286/#comment188464> Do we need to start Alarm Service separateley or should it be started as part of scheduler service? In future schedule service will suppoport more triggers apart form time trigger. In that case it will be better if we don't start those Triggers separately. lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java (line 49) <https://reviews.apache.org/r/45286/#comment188463> Not sure of the name AlaramService. Alarm generally refers to an alarming situation. Should we change it to something else (like TimeScheduler, TimeSchedulerService, TimeTriggerScheduler, TimeTriggerService)? lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java (line 128) <https://reviews.apache.org/r/45286/#comment188465> This can be a checked exception and not a RunTimeExecption. lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java (line 163) <https://reviews.apache.org/r/45286/#comment188466> Can this method tell the status of unSchedule either via a boolean result or execption to its caller. lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java (line 181) <https://reviews.apache.org/r/45286/#comment188467> What happens if server restarts after notifying the schedule event. Will/Should the schedule service retrigger this schedule on startup? - Puneet Gupta On March 24, 2016, 2:09 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45286/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 2:09 p.m.) > > > Review request for lens. > > > Bugs: LENS-987 > https://issues.apache.org/jira/browse/LENS-987 > > > Repository: lens > > > Description > ------- > > Alarm service will provide time notifications to the scheduler to trigger the > queries on a specified schedule. The schedule is built using the frequency. > > > Diffs > ----- > > lens-server-api/pom.xml 8304279 > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java > PRE-CREATION > lens-server/pom.xml 75b8b32 > lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e00 > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java > PRE-CREATION > pom.xml 06cae12 > > Diff: https://reviews.apache.org/r/45286/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
