> On March 24, 2016, 11:50 a.m., Raju Bairishetti wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java, > > line 102 > > <https://reviews.apache.org/r/45273/diff/2/?file=1313049#file1313049line102> > > > > Do we need to increase the default keep alive time to avoid frequent > > thread creations and terminations?
Yes. I think it makes sense. Increasing the timeout to 60 seconds. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45273/#review125242 ----------------------------------------------------------- On March 24, 2016, 6:36 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45273/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 6:36 a.m.) > > > Review request for lens. > > > Bugs: LENS-993 > https://issues.apache.org/jira/browse/LENS-993 > > > Repository: lens > > > Description > ------- > > - Using SynchronousQueue as in Executors.newCachedThreadPool, but pass a max > pool size for estimate pool > - Using Fixed Pool for AsyncEventListeners > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java > 84728e5 > > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java > 63c38d9 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 90c25e4 > lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java > 9955278 > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java > a2ca17f > > Diff: https://reviews.apache.org/r/45273/diff/ > > > Testing > ------- > > > Thanks, > > Amareshwari Sriramadasu > >
