----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46092/#review128644 -----------------------------------------------------------
Fix it, then Ship it! lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java (lines 227 - 231) <https://reviews.apache.org/r/46092/#comment192126> Remove comments. lens-regression/src/main/java/org/apache/lens/regression/util/Util.java (lines 229 - 232) <https://reviews.apache.org/r/46092/#comment192127> Either keep the function, or remove it completely. Don't keep it commented. lens-regression/src/test/java/org/apache/lens/regression/client/ITListQueryTest.java (line 201) <https://reviews.apache.org/r/46092/#comment192128> typo. `SpecificUser` - Rajat Khandelwal On April 12, 2016, 7:26 p.m., Archana H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46092/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 7:26 p.m.) > > > Review request for lens and Deepak Barr. > > > Bugs: LENS-1003 > https://issues.apache.org/jira/browse/LENS-1003 > > > Repository: lens > > > Description > ------- > > Add list query tests and some code cleanup > > > Diffs > ----- > > lens-regression/src/additional/java/SampleUdf.java e340ffd > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryInventory.java > e41ca86 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java > 760c088 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java > e72eb34 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java > feddb0f > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java > c829f2a > lens-regression/src/main/java/org/apache/lens/regression/util/Util.java > 7bda529 > > lens-regression/src/test/java/org/apache/lens/regression/client/ITListQueryTest.java > PRE-CREATION > > lens-regression/src/test/java/org/apache/lens/regression/client/SessionResourceTests.java > 0dad6b3 > > Diff: https://reviews.apache.org/r/46092/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.855s] > [INFO] Lens .............................................. SUCCESS [3.168s] > [INFO] Lens API .......................................... SUCCESS [29.723s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.679s] > [INFO] Lens Cube ......................................... SUCCESS > [11:26.037s] > [INFO] Lens DB storage ................................... SUCCESS [21.804s] > [INFO] Lens Query Library ................................ SUCCESS [17.529s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:17.951s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [40.370s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.355s] > [INFO] Lens Server ....................................... SUCCESS > [17:55.063s] > [INFO] Lens client ....................................... SUCCESS [35.418s] > [INFO] Lens CLI .......................................... SUCCESS [3:13.802s] > [INFO] Lens Examples ..................................... SUCCESS [10.767s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.742s] > [INFO] Lens Distribution ................................. SUCCESS [9.507s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:24.775s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.760s] > [INFO] Lens Regression ................................... SUCCESS [15.005s] > [INFO] Lens UI ........................................... SUCCESS [50.031s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 41:55.235s > [INFO] Finished at: Tue Apr 12 13:22:36 UTC 2016 > [INFO] Final Memory: 211M/2476M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Archana H > >
